Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Profile page not padding bottom inset #1212

Open
chrisbobbe opened this issue Dec 26, 2024 · 2 comments
Open

ui: Profile page not padding bottom inset #1212

chrisbobbe opened this issue Dec 26, 2024 · 2 comments
Assignees
@Gaurav-Kushwaha-1225
Labels
beta feedback Things beta users have specifically asked for
Milestone
M5: Launch

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Dec 26, 2024 •
edited
Loading

From beta feedback: https://chat.zulip.org/#narrow/channel/48-mobile/topic/Flutter.20beta.3A.20Long.20profiles.20render.20under.20navigation.20bar/near/2011825

The screenshot I provided is from a Pixel 9 Pro Fold (folded)

Implementation

ProfilePage needs a SafeArea in the appropriate place; probably wrapping the SingleChildScrollView.

This is a nice reminder that iPhones are not the only devices where SafeArea is needed 😉.
@chrisbobbe chrisbobbe added the beta feedback Things beta users have specifically asked for label Dec 26, 2024
@chrisbobbe chrisbobbe added this to the M5: Launch milestone Dec 26, 2024
@Gaurav-Kushwaha-1225
Copy link

Hi @chrisbobbe ,
Can I work on this issue?

@chrisbobbe
Copy link
Collaborator Author

Sure; please send a PR when your work is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gaurav-Kushwaha-1225 Gaurav-Kushwaha-1225

Labels
beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: No status
Milestone
M5: Launch
Development

No branches or pull requests
2 participants
@chrisbobbe @Gaurav-Kushwaha-1225