Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak dark theme for slightly higher contrast #973

Open
gnprice opened this issue Sep 30, 2024 · 5 comments · May be fixed by #1213
Open

Tweak dark theme for slightly higher contrast #973

gnprice opened this issue Sep 30, 2024 · 5 comments · May be fixed by #1213
Assignees
@Gaurav-Kushwaha-1225
Labels
a-design Visual and UX design help wanted
Milestone
M5: Launch

Comments

@gnprice
Copy link
Member

gnprice commented Sep 30, 2024 •
edited
Loading

Our colors in dark theme are based on those in web. The dark theme in web is getting adjusted to have slightly higher contrast, and we should follow. Details:

For mobile, the specific design from @terpimost can be found here:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=4514-33396&t=bMNXsr5LwkrHz4dp-1

@terpimost would you suggest using the exact same values for these in mobile as in web? Or would you prefer to update things in the mobile Figma doc?

Related (but independent) PR
@gnprice gnprice added the a-design Visual and UX design label Sep 30, 2024
@gnprice gnprice added this to the Beta 4: Fall 2024 milestone Sep 30, 2024
@IfeanyiSam

This comment was marked as outdated.

Sign in to view
@donnywellson

This comment was marked as outdated.

Sign in to view
@donnywellson

This comment was marked as outdated.

Sign in to view
@gnprice
Copy link
Member Author

gnprice commented Oct 7, 2024 •
edited
Loading

I've just updated the issue description with the design freshly provided by @terpimost, so it's possible now to work on this issue.

outdated replies

@donnywellson assigning to you; please go ahead. I'm not sure we'll want to merge rearrangements to the theme code; but as long as you keep them in separate commits, following our style for clean and coherent commits, that won't get in the way of reviewing your main changes.

@IfeanyiSam please take a look at our guide for claiming an issue:
https://zulip.readthedocs.io/en/latest/contributing/contributing.html#in-other-zulip-repositories

@PIG208 PIG208 linked a pull request Oct 8, 2024 that will close this issue
Tweak dark themes into a higher contrast #991
Closed
@chrisbobbe chrisbobbe mentioned this issue Oct 8, 2024
Closed
@gnprice gnprice mentioned this issue Nov 1, 2024
Closed
@gnprice gnprice modified the milestones: M4: Wider beta, M5: Launch Dec 11, 2024
@Gaurav-Kushwaha-1225
Copy link

Hi @gnprice,
Can you please assign this issue to me.
I have understood the issue from my side i.e., the various changes in dark theme contrast have to be implemented one by one.
Keeping them in separate commits while updating and refactoring the theme related code.
Thank you.

@Gaurav-Kushwaha-1225 Gaurav-Kushwaha-1225 linked a pull request Dec 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gaurav-Kushwaha-1225 Gaurav-Kushwaha-1225

Labels
a-design Visual and UX design help wanted
Projects
Flutter app
Status: No status
Milestone
M5: Launch
4 participants
@gnprice @donnywellson @Gaurav-Kushwaha-1225 @IfeanyiSam