-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to edit topic title #5365
Comments
I would love to work on this. This seems like an interesting feature but although less intriguing. This would be a necessary action for future updates |
Thanks for the suggestion! Looks like #4828 is a related issue, but both would be helpful. |
@Sauvikn98 if you are interested in working on this, you can dig into the code, and post a description of your proposed approach once you have an idea of how you would go about it. @chrisbobbe or @gnprice can comment on whether or not this is an approachable first issue. |
Okay! Thank you for the response. I will make a detailed proposal of my approach for this issue by the end of the day and post it for a review. |
This makes sense to me as an issue for someone to take on. One detail for the implementation: I think probably the behavior should be that when the user chooses to do this, we should ask the server to apply the change to all the messages in the topic (rather than try to make it only the messages after a certain point.) That's because in this UI flow, there doesn't seem to be a good way to have the user specify what message they'd want the rename to start from. (If the user does want to move only the messages starting from a given point, then a natural UI for that would start with long-press on that message. Issue #4828 is for offering that option, among others.) |
@gnprice would it be best to wait for zulip/zulip#21739 to be completed, or do you think it's OK to pick this up now? |
I think it's OK to pick this up for now, and we can just be conservative about when to show the option: for example, only show it when the user is at least an admin. That should cover a good fraction of the times that people want this feature. Then after zulip/zulip#21739 is done, and/or #3898 , we can adjust the logic so it more precisely shows the option in all the situations where the user has the permissions for it. |
We'll use this for zulip#5306; see the plan in discussion: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/.23M5306.20Follow.20.2Fnear.2F.20links.20through.20topic.20moves.2Frenames/near/1407930 In particular, we want the stream and topic for a stream message that might not be in our data structures. We'll use this endpoint to fetch that information. topic edit modal [nfc]: Add TopicModalProvider context component. Contains visibility context and handler callback context. Sets up context for modal handler to be called inside topic action sheets. topic edit modal [nfc]: Provide topic modal Context hook to children. The useTopicModalHandler is called normally in TopicItem and TitleStream. In order to deliver the callbacks to the action sheets in MessageList, the context hook is called in ChatScreen and a bit of prop-drilling is performed. topic edit modal: Add translation for action sheet button. topic edit modal: Add modal and functionality to perform topic name updates. Fixes zulip#5365 topid edit modal [nfc]: Revise Flow types for relevant components. topic edit modal: Modify webview unit tests to accommodate feature update.
Currently it is not possible to edit the title of a topic. I would expect such an option in the menu when holding the topic title at the top:
See the conversation on chat.zulip.org for reference: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Change.20topic.20title
The text was updated successfully, but these errors were encountered: