Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for notes without asset in transctions #654

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

feat: add support for notes without asset in transctions #654

wants to merge 3 commits into from

Conversation

tomyrd
Copy link
Collaborator

@tomyrd tomyrd commented Jan 6, 2025 •
edited
Loading

closes #652

@tomyrd tomyrd force-pushed the tomyrd-note-without-asset branch from 349e60e to 1024dab Compare January 6, 2025 18:53
@tomyrd tomyrd marked this pull request as ready for review January 6, 2025 18:53
@tomyrd tomyrd requested a review from igamigo January 6, 2025 18:53
@tomyrd tomyrd linked an issue Jan 6, 2025 that may be closed by this pull request
Possibility of creating a note without an Asset #652
Open
igamigo
igamigo approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This would work with the pay_to_id() transaction builder as well, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igamigo igamigo igamigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility of creating a note without an Asset
2 participants
@tomyrd @igamigo