-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented function for computing of old account states based on deltas #563
Open
polydez
wants to merge
34
commits into
next
Choose a base branch
from
polydez-compute-old-acc-states
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 32 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
25a82ff
feat: prepare DB structure for new delta format
polydez ea8898c
chore: remove unused dependencies
polydez 5c0f4d8
fix: delta merging bugs
polydez 209ee7b
fix: remove obsolete check in test
polydez 97389f2
fix: update directory name to correspond common format
polydez 1dfa146
feat: compute old account states by deltas in DB
polydez 419f871
refactor: rename DB tables
polydez 3b10b3c
refactor: add `WITHOUT ROWID` to tables where ROWID is unnecessary
polydez 4b5cfd8
refactor: don't require allocations and clones for `bulk_insert`
polydez 8552b12
fix: get rid of `unsafe` in `NonFungibleAsset` construction from `Word`
polydez 560d00d
Merge branch 'refs/heads/next' into polydez-refactor-deltas-in-db
polydez 9b83153
refactor: extract utils to separate module inside `sql`
polydez 8945b7f
refactor: rename `account_nonce_updates` table to `account_deltas`
polydez 9ea1f17
docs: improve function description for `select_account_state_delta`
polydez 45ce1b6
Merge branch 'next' into polydez-refactor-deltas-in-db
polydez 98fc38d
fix: compilation errors
polydez c153a52
Merge branch 'polydez-refactor-deltas-in-db' into polydez-compute-old…
polydez 3203526
fix: table names
polydez 8099914
fix: get rid of `unsafe`
polydez 9a54663
tests: implement test, fix bugs
polydez aa6d939
refactor: rename `account_hash_update_from_row` to `account_summary_f…
polydez bb22838
refactor: rename `account_hash_update_from_row` to `account_summary_f…
polydez 8fd5bb1
refactor: get rid of `u32_to_value`
polydez 42267e5
refactor: remove unnecessary indexes
polydez 431eb5a
refactor: multiple inserts instead of `bulk_insert`
polydez dbffa9a
refactor: multiple queries instead of single query with unions
polydez a4f4ed3
Merge branch 'polydez-refactor-deltas-in-db' into polydez-compute-old…
polydez ab3a196
refactor: multiple queries instead of single query with unions
polydez f075699
Merge branch 'next' into polydez-compute-old-acc-states
polydez 064aaf3
docs: fix example test for `insert_sql` macro
polydez 8b5cacb
formatting: apply rustfmt
polydez c2e387e
refactor: address review comments
polydez 9e15f5b
Merge branch 'refs/heads/next' into polydez-compute-old-acc-states
polydez 76c68b4
refactor: update to the latest `next`
polydez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a bit misleading. This method still works for non-public accounts, right? It just doesn't return details for them (ie, it just returns the stored hash). There are some other related functions that have the same problem IIRC (like
select_accounts_by_ids
whichget_account_proofs
uses, both for private and public accounts).