Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include page last modified date in footer for all pages. #4034

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

adunkman
Copy link
Member

Changes proposed in this pull request:

We're looking to indicate when pages are last modified in updates to the TTS Consulting Handbook.

Build timing

This adds 3-4 seconds to build times, which I think is reasonable for its usefulness.
2024-12-12 16:06:03 INFO [main] Running build for 18f/handbook/add-last-modified-to-footer
2024-12-12 16:06:03 INFO [clone] Cloning into '/tmp/work/site_repo'...
2024-12-12 16:06:04 INFO [clone] Fetching commit details ...
2024-12-12 16:06:04 INFO [clone] commit efaa8b0542cbce8b57a558dbeed66221f95bb545
2024-12-12 16:06:04 INFO [update] Fetching full git history
2024-12-12 16:06:07 INFO [update] From https://github.com/18f/handbook
2024-12-12 16:06:08 INFO [update] * [new tag]           last-jekyll -> last-jekyll
2024-12-12 16:06:08 INFO [update] Already up to date.
2024-12-12 16:06:08 INFO [setup-node] Checking node version specified in .nvmrc
2024-12-11 20:12:02 INFO [main] Running build for 18f/handbook/ttsc-handbook-section-A
2024-12-11 20:12:02 INFO [clone] Cloning into '/tmp/work/site_repo'...
2024-12-11 20:12:03 INFO [clone] Fetching commit details ...
2024-12-11 20:12:03 INFO [clone] commit 3a7873b1aff8b5d98b4f959afb92d43784eb9949
2024-12-11 20:12:03 INFO [update] Fetching full git history
2024-12-11 20:12:06 INFO [update] From https://github.com/18f/handbook
2024-12-11 20:12:06 INFO [update] * [new tag]           last-jekyll -> last-jekyll
2024-12-11 20:12:06 INFO [update] Already up to date.
2024-12-11 20:12:06 INFO [setup-node] Checking node version specified in .nvmrc

Security considerations

None, the git history is public information.


screenshot of footer showing date last modified

@adunkman adunkman requested a review from a team as a code owner December 12, 2024 16:17
Copy link
Member

@JJediny JJediny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adunkman adunkman merged commit bc0eb57 into main Dec 12, 2024
8 checks passed
@adunkman adunkman deleted the add-last-modified-to-footer branch December 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants