Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): bump @apidevtools/json-schema-ref-parser to 11.6.2 #256

Merged

Conversation

anaezes
Copy link
Contributor

@anaezes anaezes commented Jul 12, 2024

A dependency used in this project @apidevtools/json-schema-ref-parser is vulnerable to a prototype pollution attack, as listed in https://nvd.nist.gov/vuln/detail/CVE-2024-29651 - GHSA-5f97-h2c2-826q

This PR bumps the dependency to prevent any vulnerabilities.

Closes #255

References
https://ossindex.sonatype.org/vulnerability/CVE-2024-29651
GHSA-5f97-h2c2-826q
APIDevTools/json-schema-ref-parser@8cad7f7
https://nvd.nist.gov/vuln/detail/CVE-2024-29651

Copy link

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but the description is wrong - see comment on #255

@kiikka
Copy link

kiikka commented Sep 27, 2024

+1 to this. This old version is an issue using Node v20

@jayvdb
Copy link

jayvdb commented Oct 2, 2024

ping @philsturgeon
would be good to get a release out with this fixed

@jayvdb
Copy link

jayvdb commented Oct 4, 2024

@Yasiruofficial or @kibertoad, are you able to help with this?

@philsturgeon
Copy link
Member

philsturgeon commented Oct 7, 2024

Please be aware I have a strong feeling it was pegged to that older version due to a pesky bug which has escaped my memory, but as many of you are asking for an update on security reasons I'm going to merge this. I hope the release process happens. I hope it works. If it doesn't please shout at me a bit more bit this tool is basically abandoned and I recommend https://github.com/Redocly/redocly-cli/ these days.

@philsturgeon philsturgeon merged commit 6cf11df into APIDevTools:main Oct 7, 2024
@kibertoad
Copy link
Collaborator

@philsturgeon why not use the latest 11.7.0, though?

@kibertoad
Copy link
Collaborator

@philsturgeon maybe you would be open to invite additional maintainers and releasers, if you don't have capacity to maintain anymore? (which is very understandable)

@philsturgeon
Copy link
Member

@kibertoad: thanks for the understanding! I'd be happy to.

The amazing @jonluca has been working on other packages but dont want to overload them.

Who fancies stepping up?

Also I have no idea what version is latest or who is doing what, I just remember this package was stuck on an old version because things broke but that was years ago. I'm trying to get it working locally as Github Actions are failing but this is cutting into time for the crowdfunder im running to buy another 70 acres of woodland in Bath UK and that's stressing me out.

@philsturgeon
Copy link
Member

This did not work.

Error: Cannot find module '@apidevtools/json-schema-ref-parser/lib/util/url'

That's on me for not having test checks enabled, but somebody is going to need to submit a fix for that.

@kibertoad
Copy link
Collaborator

@philsturgeon I have plenty of packages on my plate already, but I can help with reviewing PRs and cutting releases here and there.

@philsturgeon
Copy link
Member

That's what we need. I honestly couldn't tell you whats going on here so you're already more qualified. I'm cleaning my spades for another winter of planting and sharpening my chainsaw for another season of mangling rhododenrons. I couldn't care any less about this package, no offense to anyone who uses it. 🤣

@kibertoad
Copy link
Collaborator

@philsturgeon sounds good then, if you give me repo steward permissions and npm publish ones, I can see what I can do

@jayvdb
Copy link

jayvdb commented Oct 7, 2024

They did the rewrite from JS to TS in the "minor" release v10.1.0

Most things are still there, rearranged a little, but https://github.com/APIDevTools/swagger-parser/blob/8a956fa/lib/options.js here seems to be very incompatible with the ParserOptions type that is exported now.

@jonluca
Copy link
Contributor

jonluca commented Oct 7, 2024

Is there something I can help with? Happy to fix anything specific that comes up

@kibertoad
Copy link
Collaborator

@jonluca Can you look into fixing CI? master seems to be failing :-/. and adding recent Node versions into the mix would be great

@jonluca
Copy link
Contributor

jonluca commented Oct 10, 2024

I've fixed CI and cleaned up some of the stuff that was super broken. I think it probably makes sense to release this as a breaking change since there were so many small differences in json-schema-ref-parser though.

#261

@philsturgeon
Copy link
Member

@jonluca thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump dependency due to a vulnerable package
6 participants