feat(anti-aliasing): Implement optional FXAA anti-aliasing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename the final FXAA function from apply to applyFXAA to import clarity and to free up the name apply
rename useShaderPass parameters interface to be more self-explanatory
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR closes #1 by introducing an optional FXAA anti-aliasing feature to enhance visual quality and smoothen out the 'jaggy' edges. Moreover, as requested in the issue, the antialiasing is togglable, allowing end users to be able to switch it on or off depending on their needs.
Changes:
Testing:
Screenshots:
Before FXAA:
After FXAA:
As can be seen by observing the edges of the cube, there is a great improvement and the edges appear more natural and the staircase effect has been greatly mitigated.
Checklist: