Improvements to geometry paths #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jstone-lucasfilm
commented
Oct 4, 2023
jstone-lucasfilm
commented
- Improve the implementation of GeomPath::string, adding a required leading separator for non-empty paths.
- Improve the robustness of joinStrings, adding support for input vectors with empty leading elements.
- Add unit tests for GeomPath::string.
- Improve the implementation of GeomPath::string, adding a required leading separator for non-empty paths. - Improve the robustness of joinStrings, adding support for input vectors with empty leading elements. - Add unit tests for GeomPath::string.
jstone-lucasfilm
merged commit 6bb5d1e
into
AcademySoftwareFoundation:main
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.