Fix edge case in HW shader generation for texcoords #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges both `TexCoordNodeMsl` and `TexCoordNodeGlsl` into a single `HwTexCoordNode`. The parts of the node that are configurable (e.g. the input index) can be changed via re-implementation of the virtual member function `getIndexInput()`. The new mechanism works regardless of syntax, and uses the smallest texcoord width, depending on what is used in the shader graph.
|
This looks really promising, thanks @madmann91! If the EasyCLA system isn't working as expected, feel free to submit a support request ticket as described above, and the Linux Foundation is usually very quick in resolving these issues. |
kwokcb
reviewed
Oct 12, 2023
|
/easycla |
kwokcb
reviewed
Oct 13, 2023
jstone-lucasfilm
changed the title
Signed-off-by: Jonathan Stone <[email protected]>
Signed-off-by: Jonathan Stone <[email protected]>
jstone-lucasfilm
approved these changes
Oct 13, 2023
jstone-lucasfilm
merged commit 54adaee
into
AcademySoftwareFoundation:main
30 checks passed
Michaelredaa
pushed a commit
to Michaelredaa/MaterialX
that referenced
this pull request
Oct 21, 2023
…oundation#1559) This merges both TexCoordNodeMsl and TexCoordNodeGlsl into a single HwTexCoordNode. The parts of the node that are configurable (e.g. the input index) can be changed via re-implementation of the virtual member function getIndexInput(). The new mechanism works regardless of syntax, and uses the smallest texcoord width, depending on what is used in the shader graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges both
TexCoordNodeMslandTexCoordNodeGlslinto a singleHwTexCoordNode. The parts of the node that are configurable (e.g. the input index) can be changed via re-implementation of the virtual member functiongetIndexInput().The new mechanism works regardless of syntax, and uses the smallest texcoord width, depending on what is used in the shader graph.
Fixes #1464