Merge pull request #1936 from Adyen/feature/analytics_track_api_errors

Analytics - Track api errors

3ds2/src/main/java/com/adyen/checkout/adyen3ds2/internal/ui/DefaultAdyen3DS2Delegate.kt

@@ -269,8 +269,8 @@ internal class DefaultAdyen3DS2Delegate(
         val coroutineExceptionHandler = CoroutineExceptionHandler { _, throwable ->
             adyenLog(AdyenLogLevel.ERROR, throwable) { "Unexpected uncaught 3DS2 Exception" }
             trackFingerprintErrorEvent(
-                errorEvent = ErrorEvent.THREEDS2_FINGERPRINT_CREATION,
-                message = "Fingerprint creation failed because of uncaught exception",
+                errorEvent = ErrorEvent.THREEDS2_FINGERPRINT_HANDLING,
+                message = "Fingerprint handling failed because of uncaught exception",
             )
             emitError(CheckoutException("Unexpected 3DS2 exception.", throwable))
         }
@@ -436,7 +436,7 @@ internal class DefaultAdyen3DS2Delegate(
             .fold(
                 onSuccess = { result -> onSubmitFingerprintResult(result, activity) },
                 onFailure = { e ->
-                    trackFingerprintErrorEvent(ErrorEvent.THREEDS2_FINGERPRINT_HANDLING)
+                    trackFingerprintErrorEvent(ErrorEvent.API_THREEDS2)
                     emitError(ComponentException("Unable to submit fingerprint", e))
                 },
             )

3ds2/src/test/java/com/adyen/checkout/adyen3ds2/internal/ui/DefaultAdyen3DS2DelegateTest.kt

@@ -752,7 +752,7 @@ internal class DefaultAdyen3DS2DelegateTest(
             delegate.identifyShopper(Activity(), encodedJson, false)
 
             val expectedEvent = ThreeDS2Events.threeDS2FingerprintError(
-                event = ErrorEvent.THREEDS2_FINGERPRINT_CREATION,
+                event = ErrorEvent.THREEDS2_FINGERPRINT_HANDLING,
             )
             analyticsManager.assertLastEventEquals(expectedEvent)
         }
@@ -837,7 +837,7 @@ internal class DefaultAdyen3DS2DelegateTest(
             delegate.identifyShopper(Activity(), encodedJson, true)
 
             val expectedEvent = ThreeDS2Events.threeDS2FingerprintError(
-                event = ErrorEvent.THREEDS2_FINGERPRINT_HANDLING,
+                event = ErrorEvent.API_THREEDS2,
             )
             analyticsManager.assertLastEventEquals(expectedEvent)
         }

ach/src/main/java/com/adyen/checkout/ach/internal/provider/ACHDirectDebitComponentProvider.kt

@@ -516,6 +516,7 @@ constructor(
             ),
             sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
             isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+            analyticsManager = analyticsManager,
         )
 
         return SessionComponentEventHandler(

ach/src/main/java/com/adyen/checkout/ach/internal/ui/DefaultACHDirectDebitDelegate.kt

@@ -201,6 +201,10 @@ internal class DefaultACHDirectDebitDelegate(
                 },
                 onFailure = { e ->
                     adyenLog(AdyenLogLevel.ERROR) { "Unable to fetch public key" }
+
+                    val event = GenericEvents.error(paymentMethod.type.orEmpty(), ErrorEvent.API_PUBLIC_KEY)
+                    analyticsManager.trackEvent(event)
+
                     exceptionChannel.trySend(ComponentException("Unable to fetch publicKey.", e))
                 },
             )

ach/src/test/java/com/adyen/checkout/ach/internal/ui/DefaultACHDirectDebitDelegateTest.kt

@@ -690,6 +690,14 @@ internal class DefaultACHDirectDebitDelegateTest(
             assertEquals(TEST_CHECKOUT_ATTEMPT_ID, componentState.data.paymentMethod?.checkoutAttemptId)
         }
 
+        @Test
+        fun `when fetching the public key fails, then an error event is tracked`() = runTest {
+            publicKeyRepository.shouldReturnError = true
+            delegate.initialize(CoroutineScope(UnconfinedTestDispatcher()))
+            val expectedEvent = GenericEvents.error(TEST_PAYMENT_METHOD_TYPE, ErrorEvent.API_PUBLIC_KEY)
+            analyticsManager.assertLastEventEquals(expectedEvent)
+        }
+
         @Test
         fun `when delegate is cleared then analytics manager is cleared`() {
             delegate.onCleared()

bacs/src/main/java/com/adyen/checkout/bacs/internal/provider/BacsDirectDebitComponentProvider.kt

@@ -215,6 +215,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
             val sessionComponentEventHandler = SessionComponentEventHandler<BacsDirectDebitComponentState>(
                 sessionInteractor = sessionInteractor,

bcmc/src/main/java/com/adyen/checkout/bcmc/internal/provider/BcmcComponentProvider.kt

@@ -267,6 +267,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
 
             val sessionComponentEventHandler = SessionComponentEventHandler<BcmcComponentState>(

blik/src/main/java/com/adyen/checkout/blik/internal/provider/BlikComponentProvider.kt

@@ -318,6 +318,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
 
             val sessionComponentEventHandler = SessionComponentEventHandler<BlikComponentState>(
@@ -425,6 +426,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
 
             val sessionComponentEventHandler =

boleto/src/main/java/com/adyen/checkout/boleto/internal/provider/BoletoComponentProvider.kt

@@ -224,6 +224,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
 
             val sessionComponentEventHandler =

card/src/main/java/com/adyen/checkout/card/internal/provider/CardComponentProvider.kt

@@ -291,6 +291,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
             val sessionComponentEventHandler = SessionComponentEventHandler<CardComponentState>(
                 sessionInteractor = sessionInteractor,
@@ -504,6 +505,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
             val sessionComponentEventHandler = SessionComponentEventHandler<CardComponentState>(
                 sessionInteractor = sessionInteractor,

card/src/main/java/com/adyen/checkout/card/internal/ui/DefaultCardDelegate.kt

@@ -219,6 +219,10 @@ class DefaultCardDelegate(
                 },
                 onFailure = { e ->
                     adyenLog(AdyenLogLevel.ERROR) { "Unable to fetch public key" }
+
+                    val event = GenericEvents.error(paymentMethod.type.orEmpty(), ErrorEvent.API_PUBLIC_KEY)
+                    analyticsManager.trackEvent(event)
+
                     exceptionChannel.trySend(ComponentException("Unable to fetch publicKey.", e))
                 },
             )

card/src/main/java/com/adyen/checkout/card/internal/ui/StoredCardDelegate.kt

@@ -198,6 +198,9 @@ internal class StoredCardDelegate(
                     updateComponentState(outputData)
                 },
                 onFailure = { e ->
+                    val event = GenericEvents.error(storedPaymentMethod.type.orEmpty(), ErrorEvent.API_PUBLIC_KEY)
+                    analyticsManager.trackEvent(event)
+
                     exceptionChannel.trySend(ComponentException("Unable to fetch publicKey.", e))
                 },
             )

card/src/test/java/com/adyen/checkout/card/internal/ui/DefaultCardDelegateTest.kt

@@ -1095,6 +1095,14 @@ internal class DefaultCardDelegateTest(
             }
         }
 
+        @Test
+        fun `when fetching the public key fails, then an error event is tracked`() = runTest {
+            publicKeyRepository.shouldReturnError = true
+            delegate.initialize(CoroutineScope(UnconfinedTestDispatcher()))
+            val expectedEvent = GenericEvents.error(PaymentMethodTypes.SCHEME, ErrorEvent.API_PUBLIC_KEY)
+            analyticsManager.assertLastEventEquals(expectedEvent)
+        }
+
         @Test
         fun `when delegate is cleared then analytics manager is cleared`() {
             delegate.onCleared()

card/src/test/java/com/adyen/checkout/card/internal/ui/StoredCardDelegateTest.kt

@@ -485,6 +485,14 @@ internal class StoredCardDelegateTest(
             }
         }
 
+        @Test
+        fun `when fetching the public key fails, then an error event is tracked`() = runTest {
+            publicKeyRepository.shouldReturnError = true
+            delegate.initialize(CoroutineScope(UnconfinedTestDispatcher()))
+            val expectedEvent = GenericEvents.error(CardPaymentMethod.PAYMENT_METHOD_TYPE, ErrorEvent.API_PUBLIC_KEY)
+            analyticsManager.assertLastEventEquals(expectedEvent)
+        }
+
         @Test
         fun `when delegate is cleared then analytics manager is cleared`() {
             delegate.onCleared()

cashapppay/src/main/java/com/adyen/checkout/cashapppay/internal/provider/CashAppPayComponentProvider.kt

@@ -472,6 +472,7 @@ constructor(
             ),
             sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
             isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+            analyticsManager = analyticsManager,
         )
 
         return SessionComponentEventHandler(

components-core/src/main/java/com/adyen/checkout/components/core/internal/analytics/ErrorEvent.kt

@@ -26,9 +26,7 @@ enum class ErrorEvent(val errorType: Type, val errorCode: String) {
 
     // API
     API_PAYMENTS(Type.API_ERROR, "620"),
-    API_PAYMENTS_DETAILS(Type.API_ERROR, "621"),
     API_THREEDS2(Type.API_ERROR, "622"),
-    API_ORDER(Type.API_ERROR, "623"),
     API_PUBLIC_KEY(Type.API_ERROR, "624"),
     API_NATIVE_REDIRECT(Type.API_ERROR, "625"),
 

drop-in/api/drop-in.api

@@ -338,7 +338,7 @@ public final class com/adyen/checkout/dropin/SessionDropInResultContract : andro
 
 public class com/adyen/checkout/dropin/SessionDropInService : com/adyen/checkout/dropin/internal/service/BaseDropInService, com/adyen/checkout/dropin/SessionDropInServiceContract, com/adyen/checkout/dropin/internal/service/SessionDropInServiceInterface {
 	public fun <init> ()V
-	public final fun initialize (Lcom/adyen/checkout/sessions/core/SessionModel;Ljava/lang/String;Lcom/adyen/checkout/core/Environment;Z)V
+	public final fun initialize (Lcom/adyen/checkout/sessions/core/SessionModel;Ljava/lang/String;Lcom/adyen/checkout/core/Environment;ZLcom/adyen/checkout/components/core/internal/analytics/AnalyticsManager;)V
 	public final fun isFlowTakenOver ()Z
 	public fun onAdditionalDetails (Lcom/adyen/checkout/components/core/ActionComponentData;)Z
 	public fun onBalanceCheck (Lcom/adyen/checkout/components/core/PaymentComponentState;)Z

drop-in/src/main/java/com/adyen/checkout/dropin/SessionDropInService.kt

@@ -13,6 +13,7 @@ import com.adyen.checkout.components.core.OrderRequest
 import com.adyen.checkout.components.core.OrderResponse
 import com.adyen.checkout.components.core.PaymentComponentState
 import com.adyen.checkout.components.core.StoredPaymentMethod
+import com.adyen.checkout.components.core.internal.analytics.AnalyticsManager
 import com.adyen.checkout.core.AdyenLogLevel
 import com.adyen.checkout.core.Environment
 import com.adyen.checkout.core.internal.data.api.HttpClientFactory
@@ -50,7 +51,8 @@ open class SessionDropInService : BaseDropInService(), SessionDropInServiceInter
         sessionModel: SessionModel,
         clientKey: String,
         environment: Environment,
-        isFlowTakenOver: Boolean
+        isFlowTakenOver: Boolean,
+        analyticsManager: AnalyticsManager,
     ) {
         val httpClient = HttpClientFactory.getHttpClient(environment)
         val sessionService = SessionService(httpClient)
@@ -61,6 +63,7 @@ open class SessionDropInService : BaseDropInService(), SessionDropInServiceInter
             ),
             sessionModel = sessionModel,
             isFlowTakenOver = isFlowTakenOver,
+            analyticsManager = analyticsManager,
         )
         this.isFlowTakenOver = isFlowTakenOver
 

drop-in/src/main/java/com/adyen/checkout/dropin/internal/service/BaseDropInServiceInterfaces.kt

@@ -14,6 +14,7 @@ import com.adyen.checkout.components.core.LookupAddress
 import com.adyen.checkout.components.core.OrderRequest
 import com.adyen.checkout.components.core.PaymentComponentState
 import com.adyen.checkout.components.core.StoredPaymentMethod
+import com.adyen.checkout.components.core.internal.analytics.AnalyticsManager
 import com.adyen.checkout.core.Environment
 import com.adyen.checkout.dropin.BaseDropInServiceResult
 import com.adyen.checkout.sessions.core.SessionModel
@@ -39,6 +40,7 @@ internal interface SessionDropInServiceInterface : BaseDropInServiceInterface {
         sessionModel: SessionModel,
         clientKey: String,
         environment: Environment,
-        isFlowTakenOver: Boolean
+        isFlowTakenOver: Boolean,
+        analyticsManager: AnalyticsManager,
     )
 }

drop-in/src/main/java/com/adyen/checkout/dropin/internal/ui/DropInActivity.kt

@@ -585,6 +585,7 @@ internal class DropInActivity :
             clientKey = event.clientKey,
             environment = event.environment,
             isFlowTakenOver = event.isFlowTakenOver,
+            analyticsManager = event.analyticsManager,
         )
     }
 
@@ -728,8 +729,6 @@ internal class DropInActivity :
         private const val LOADING_FRAGMENT_TAG = "LOADING_DIALOG_FRAGMENT"
         private const val GIFT_CARD_PAYMENT_CONFIRMATION_FRAGMENT_TAG = "GIFT_CARD_PAYMENT_CONFIRMATION_FRAGMENT"
 
-        internal const val GOOGLE_PAY_REQUEST_CODE = 1
-
         fun createIntent(
             context: Context,
             checkoutConfiguration: CheckoutConfiguration,

drop-in/src/main/java/com/adyen/checkout/dropin/internal/ui/DropInViewModel.kt

@@ -203,6 +203,7 @@ internal class DropInViewModel(
             clientKey = dropInParams.clientKey,
             environment = dropInParams.environment,
             isFlowTakenOver = isSessionsFlowTakenOver,
+            analyticsManager = analyticsManager,
         )
         sendEvent(event)
     }

drop-in/src/main/java/com/adyen/checkout/dropin/internal/ui/model/DropInActivityEvent.kt

@@ -11,6 +11,7 @@ package com.adyen.checkout.dropin.internal.ui.model
 import com.adyen.checkout.components.core.OrderRequest
 import com.adyen.checkout.components.core.PaymentComponentState
 import com.adyen.checkout.components.core.PaymentMethod
+import com.adyen.checkout.components.core.internal.analytics.AnalyticsManager
 import com.adyen.checkout.core.Environment
 import com.adyen.checkout.sessions.core.SessionModel
 
@@ -25,6 +26,7 @@ internal sealed class DropInActivityEvent {
         val clientKey: String,
         val environment: Environment,
         val isFlowTakenOver: Boolean,
+        val analyticsManager: AnalyticsManager,
     ) : DropInActivityEvent()
 }
 

econtext/src/main/java/com/adyen/checkout/econtext/internal/provider/EContextComponentProvider.kt

@@ -223,6 +223,7 @@ constructor(
                     ),
                     sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                     isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                    analyticsManager = analyticsManager,
                 )
                 val sessionComponentEventHandler = SessionComponentEventHandler<ComponentStateT>(
                     sessionInteractor = sessionInteractor,

giftcard/src/main/java/com/adyen/checkout/giftcard/internal/provider/GiftCardComponentProvider.kt

@@ -232,6 +232,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
 
             val sessionsGiftCardComponentEventHandler = SessionsGiftCardComponentEventHandler(

giftcard/src/main/java/com/adyen/checkout/giftcard/internal/ui/DefaultGiftCardDelegate.kt

@@ -129,6 +129,10 @@ class DefaultGiftCardDelegate(
                 },
                 onFailure = { e ->
                     adyenLog(AdyenLogLevel.ERROR) { "Unable to fetch public key" }
+
+                    val event = GenericEvents.error(paymentMethod.type.orEmpty(), ErrorEvent.API_PUBLIC_KEY)
+                    analyticsManager.trackEvent(event)
+
                     exceptionChannel.trySend(ComponentException("Unable to fetch publicKey.", e))
                 },
             )

giftcard/src/test/java/com/adyen/checkout/giftcard/internal/ui/DefaultGiftCardDelegateTest.kt

@@ -410,6 +410,14 @@ internal class DefaultGiftCardDelegateTest(
             }
         }
 
+        @Test
+        fun `when fetching the public key fails, then an error event is tracked`() = runTest {
+            publicKeyRepository.shouldReturnError = true
+            delegate.initialize(CoroutineScope(UnconfinedTestDispatcher()))
+            val expectedEvent = GenericEvents.error(TEST_PAYMENT_METHOD_TYPE, ErrorEvent.API_PUBLIC_KEY)
+            analyticsManager.assertLastEventEquals(expectedEvent)
+        }
+
         @Test
         fun `when delegate is cleared then analytics manager is cleared`() {
             delegate.onCleared()

googlepay/src/main/java/com/adyen/checkout/googlepay/internal/provider/GooglePayComponentProvider.kt

@@ -231,6 +231,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
 
             val sessionComponentEventHandler = SessionComponentEventHandler<GooglePayComponentState>(

ideal/src/main/java/com/adyen/checkout/ideal/internal/provider/IdealComponentProvider.kt

@@ -209,6 +209,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
             val sessionComponentEventHandler = SessionComponentEventHandler<IdealComponentState>(
                 sessionInteractor = sessionInteractor,

instant/src/main/java/com/adyen/checkout/instant/internal/provider/InstantPaymentComponentProvider.kt

@@ -213,6 +213,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
             val sessionComponentEventHandler = SessionComponentEventHandler<InstantComponentState>(
                 sessionInteractor = sessionInteractor,

issuer-list/src/main/java/com/adyen/checkout/issuerlist/internal/provider/IssuerListComponentProvider.kt

@@ -222,6 +222,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
             val sessionComponentEventHandler = SessionComponentEventHandler<ComponentStateT>(
                 sessionInteractor = sessionInteractor,

mbway/src/main/java/com/adyen/checkout/mbway/internal/provider/MBWayComponentProvider.kt

@@ -216,6 +216,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
 
             val sessionComponentEventHandler = SessionComponentEventHandler<MBWayComponentState>(

meal-voucher-fr/src/main/java/com/adyen/checkout/mealvoucherfr/internal/provider/MealVoucherFRComponentProvider.kt

@@ -232,6 +232,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
 
             val sessionsGiftCardComponentEventHandler = SessionsGiftCardComponentEventHandler(

online-banking-core/src/main/java/com/adyen/checkout/onlinebankingcore/internal/provider/OnlineBankingComponentProvider.kt

@@ -231,6 +231,7 @@ constructor(
                 ),
                 sessionModel = sessionSavedStateHandleContainer.getSessionModel(),
                 isFlowTakenOver = sessionSavedStateHandleContainer.isFlowTakenOver ?: false,
+                analyticsManager = analyticsManager,
             )
             val sessionComponentEventHandler = SessionComponentEventHandler<ComponentStateT>(
                 sessionInteractor = sessionInteractor,