Explicitly configure ContractResolver for SaleToPOIMessage serialization #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwok-he-Chu
requested changes
Dec 23, 2024
Adyen/ApiSerialization/Converter/JsonConvertSerializerWrapper.cs
Outdated
Show resolved
Hide resolved
|
Kwok-he-Chu
approved these changes
Dec 31, 2024
|
@Kwok-he-Chu, could you merge my changes, please? I don't have permissions even after your approval. Thank you. |
|
Merged, thank you for the contribution! @alexander-olesiyuk-apaleo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly configure
ContractResolverforSaleToPOIMessageandSaleToPoiMessageSecuredserialization to useDefaultContractResolver. This is necessary to always use the same property naming strategy and not depend onJsonConvert.DefaultSettingsas it can be changed by running app which can cause failure when parsing request on the server.Tested scenarios
Added tests for
SaleToPoiMessageandSaleToPoiMessageSecuredwhich compare results of serialization whenJsonConvert.DefaultSettingsare not set and configured to useCamelCaseNamingStrategy. ForSaleToPoiMessageSecuredclearedSecurityTrailer.NonceandNexoBlobas they are different for each execution.Fixed issue: #1093