Fastlane Card Component signup #3043
Open
+1,169
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: +10.8 kB (+1.39%) Total Size: 788 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
ribeiroguilherme
changed the title
ribeiroguilherme
requested review from
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
|
I know you say we don't validate the mobile number - but it feels wrong that you can submit this PM whilst the field is visible, but clearly not filled |
Yea I agree. It is weird.. the main point for now is to not ruin the conversion if the shopper didn't enter the phone or entered the wrong phone.. |
sponglord
approved these changes
Jan 7, 2025
|
longyulongyu
reviewed
Jan 9, 2025
| &-header { | ||
| grid-area: header; | ||
| margin: 0; | ||
| line-height: token('text-title-m-line-height'); |
There was a problem hiding this comment.
I think no need to add ' when using the token for the consistency reason, I believe it's still working.
| @@ -1,5 +1,7 @@ | |||
| @use 'mixins'; | |||
| @use 'styles/mixins'; | |||
| @import 'styles/variable-generator'; | |||
There was a problem hiding this comment.
I think no need to import styles/variable-generator? No token is used in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the Fastlane UI inside the Card component.
How it works:
fastlaneConfigurationobjectSome highlights:
Linkcomponent which we can use for hyperlinksstaticValueto theFieldcomponent, so we can display static values (similar to how Bento does)fastlaneDataproperty, which is an encoded blob containing the data for the paymentThis flow can be tested through Storybook on the Fastlane stories.
Tests
Next PR's: