Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the deadline for the allocating requests #740

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Dec 17, 2024

The resource pool will preferentially use returned IPs. allocatingV4 represents the number of IPs requested from the openAPI. In this scenario, this number will not decrease. This typically does not pose an issue, but in some cases, if requests to the openAPI continually fail, it may result in the task running indefinitely.

@l1b0k l1b0k requested a review from BSWANG December 17, 2024 03:02
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 73.87387% with 29 lines in your changes missing coverage. Please review.

Project coverage is 23.30%. Comparing base (37a2f58) to head (369aff7).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pkg/eni/local.go 77.89% 14 Missing and 7 partials ⚠️
pkg/eni/manager.go 0.00% 4 Missing ⚠️
daemon/daemon.go 0.00% 2 Missing ⚠️
pkg/eni/types.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   21.36%   23.30%   +1.93%     
==========================================
  Files         121      121              
  Lines       15915    16011      +96     
==========================================
+ Hits         3400     3731     +331     
+ Misses      12135    11870     -265     
- Partials      380      410      +30     
Flag Coverage Δ
unittests 23.30% <73.87%> (+1.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BSWANG BSWANG merged commit 3e9786e into AliyunContainerService:main Jan 2, 2025
9 checks passed
@l1b0k l1b0k deleted the fix/ctx branch January 3, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants