Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remoteWebsiteInstall.sh fixes #4096

Merged
merged 20 commits into from
Dec 21, 2024
Merged

Conversation

EricClaeys
Copy link
Collaborator

Fixes #4084

Several fixes and enhancements to remoteWebsiteInstall.sh. See each commit for details.

EricClaeys and others added 20 commits December 18, 2024 03:44
Do NOT delete it because it probably contains files the user needs.
* Don't check if files exist before removing them (the check doesn't work for all files).
* Misc. wording changes to messages.
* Others
For some reason sourcing in variables.sh causes every subsequent line in every file to give SC2317 errors
Update ci_shellcheck.yml: Ignore SC2317
To be consistent with everything else.
And make debug statement more obvious.
Also:

* Add comment for future fix
* Make final message to user easier to read.
* Only update ALLSKY_VERSION if needed.
* Ignore thumbnails
* Shorten postData.sh output
…er sees it

Also:
* Added variables for indenting for consistency.
Also:
* Change myFiles dialog to msgbox so user sees it
* Added variables for indenting for consistency.
* Improve message about no working Website.
@EricClaeys EricClaeys added the bug Needs software change label Dec 21, 2024
@EricClaeys EricClaeys added this to the v2024.12.06 milestone Dec 21, 2024
@EricClaeys EricClaeys self-assigned this Dec 21, 2024
@Alex-developer Alex-developer merged commit 027c5fc into master Dec 21, 2024
1 check passed
@Alex-developer Alex-developer deleted the remoteWebsiteInstall.sh-fixes branch December 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs software change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remoteWebsiteInstall.sh doesn't handle remote Websites without a config file
2 participants