Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path collision on case-insensitive FS #421

Closed
wants to merge 1 commit into from
Closed

Fix path collision on case-insensitive FS #421

wants to merge 1 commit into from

Conversation

dbaynard
Copy link

@dbaynard dbaynard commented Mar 7, 2024

The modules/Src and modules/src paths collide on MacOS (for example) and Src is preferred, meaning builds fail.

This replaces the modules/Src/Aloxaf.gitignore with entries in the modules/.gitignore that does a similar thing (it actually ignores the whole Src directory).

Fixes #420

The `modules/Src` and `modules/src` paths collide on MacOS (for
example) and `Src` is preferred, meaning builds fail.

This replaces the `modules/Src/Aloxaf.gitignore` with entries in
the `modules/.gitignore` that does a similar thing (it actually
ignores the whole `Src` directory).

Fixes #420
@dbaynard dbaynard marked this pull request as ready for review March 7, 2024 04:20
@Aloxaf
Copy link
Owner

Aloxaf commented Mar 8, 2024

This is a historical issue. The Src directory was used to store built module. Removing it could cause build process failures or users have to to rebuild the module.

I suggest merging the src directory into Src.

Relevant code:

ln -s $PWD/src/fzftab.c ./zsh/$zsh_version/Src/Modules/
ln -s $PWD/src/fzftab.mdd ./zsh/$zsh_version/Src/Modules/

@Aloxaf Aloxaf closed this in #422 Mar 12, 2024
@dbaynard dbaynard deleted the fix/case-insensitive-path-collision branch March 13, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] source directory name confliction on case-insensitive filessytem such as APFS for macos
2 participants