Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

如果success为false,那require放在这里会导致回滚,后面逻辑并不会执行 #842

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

koeltp
Copy link
Contributor

@koeltp koeltp commented Nov 22, 2024

What type of PR is this (这是什么类型的PR)

  • Typo(勘误)
  • [✔ ] BUG(程序错误)
  • Improvement(提升)
  • Feature(新特性)

Which issue(s) this PR fixes(Optional) (这个PR 修复了什么问题 (可选择))

如果success为false,那require放在这里会导致回滚,后面的else逻辑不会执行。还请指教。

  • resolve: #
    注释这行 require(success , "WTF5004");
    //require(success , "WTF5004");

What this PR does / why we need it (这个PR 做了什么/ 我们为什么需要这个PR)

如果success为false,那require放在这里会导致回滚,后面的else逻辑不会执行。还请指教。
@koeltp koeltp changed the title Update MultisigWallet.sol 如果success为false,那require放在这里会导致回滚,后面逻辑并不会执行 Nov 22, 2024
@XdpCs
Copy link
Collaborator

XdpCs commented Nov 22, 2024

Thanks for your contributions. I will check it out.

@XdpCs XdpCs self-requested a review November 22, 2024 13:40
@XdpCs
Copy link
Collaborator

XdpCs commented Nov 24, 2024

可能需要更新一下 教程中md的bug

@XdpCs
Copy link
Collaborator

XdpCs commented Nov 24, 2024

我先给你合并进去,文档中的问题我去修改 @koeltp

@XdpCs XdpCs merged commit 061af09 into AmazingAng:main Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants