Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a notification system to the medical data application #25

Closed
wants to merge 8 commits into from

Conversation

robdavis95
Copy link

No description provided.

AlexJ96 and others added 8 commits November 22, 2016 22:12
Added database bypass for login
Basic notifications added
Added a updateInfoNotification & tickerTimeNotification.
Tested against API 10 to 24 and documented results
Implemented asking the user for daily updates about their personal medical information.
@Ana06
Copy link
Owner

Ana06 commented Dec 22, 2016

This is #9, right? 😄

Copy link
Owner

@Ana06 Ana06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful to leave as it was before everything you change for testing proposes.

Also, I don't understand what you mean by Add files via upload in your first commit

@@ -70,7 +71,7 @@ protected void onRestart() {
* the database last entry.
*/
private void setMainView() {
boolean firstTime = settings.getBoolean("firstTime", true);
boolean firstTime = settings.getBoolean("firstTime", false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change that? 😕

@@ -1,23 +1,20 @@
package com.example.ana.exampleapp;

import java.util.Calendar;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the order of the import?

@@ -1,37 +1,34 @@
package com.example.ana.exampleapp;

import java.lang.String;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the order of the import?

MongoClientURI mongoClientURI = new MongoClientURI(Variables.mongo_uri);
MongoClient mongoClient = new MongoClient(mongoClientURI);
MongoDatabase dbMongo = mongoClient.getDatabase(mongoClientURI.getDatabase());
//MongoClientURI mongoClientURI = new MongoClientURI(Variables.mongo_uri);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change this?

@@ -17,14 +17,13 @@
*/
public final class Variables {
// The server IP
private static final String IP = "IP";
private static final String IP = "localhost";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ok with this change as this will be most of the time the case, but then I will add in a comment called something like Adapt the project to work in the development environment

private static final String PORT = "27017";
// MongoDB uri with the IP, authentication (user, password and mechanism), database, etc.
public static final String mongo_uri = "mongodb://androidUser:password@" + IP + ":" + PORT +
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with commenting this line as this will be the case when developing, but please don't remove it as in a production environment authentication is needed. You can also added in a commit called something like Adapt the project to work in the development environment

@@ -165,7 +175,21 @@ public boolean onOptionsItemSelected(MenuItem item) {
* @param view the {@link View} that calls the method
*/
public void btnStart(View view) {
int pin = settings.getInt("pin", 0);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have you removed this? It seems to be for testing proposes, so please remove it!

@Ana06
Copy link
Owner

Ana06 commented Dec 22, 2016

I am not pretty sure if you are developing this because you plan to use it, in that case please tell me how you want to do that so I can help you. If not I will tell you what the initial idea was. 😄

@robdavis95 robdavis95 closed this Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants