[Test] Transaction phases measurement, system call way. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| transaction = transactionWriter.beginTxn(); | ||
| // Start measurement - wait until transaction is OPEN | ||
| this.stateChangedCommitting = this.getTimeStatusReached(transaction, Transaction.Status.OPEN); |
There was a problem hiding this comment.
The line is not needed - transaction is in OPEN stated after beginTxn() is called. (it's sync method)
| @@ -80,6 +86,16 @@ public PravegaBenchmarkTransactionProducer(String streamName, EventStreamClientF | |||
| if (++eventCount >= eventsPerTransaction) { | |||
| eventCount = 0; | |||
| transaction.commit(); | |||
| // Measure OPEN<->COMMITTING | |||
| final long beingCommittingTime = this.getTimeStatusReached(transaction, Transaction.Status.COMMITTING); | |||
There was a problem hiding this comment.
Same as with beginTxn() - implicit call is not needed.
There was a problem hiding this comment.
We must wrap commit() and beginTxn() separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary solution to measure transaction phases in system call way until "Prometheus" (MicroMeter) way would work.