feat: Add inline text editor to edit the tag description #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hemahg <[email protected]>
lordrip
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Hi @hemahg, while this looks good, did you consider using an existing component, for example the one from Kaoto? The advantage would be that it already contains test and is based on patternfly as well.
|
@lordripl, Thanks for sharing the kaoto example, I will check it. |
riccardo-forina
force-pushed
the
main
branch
2 times, most recently
from
3f93986 to
4129062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add inline text editor to edit the tag description