-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DroneerF405 hwdef #28846
base: master
Are you sure you want to change the base?
add DroneerF405 hwdef #28846
Conversation
I recommend these changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a README.md
Suggest the changes I outlined
OSCILLATOR_HZ 8000000 | ||
|
||
# board ID for firmware load | ||
APJ_BOARD_ID 1054 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ID is used. Please reserve an unused id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DroneerUAV to be clear, you need to make an entry in Tools/AP_Bootloader/board_types.txt
, reserving an ID for your board. You then you use either that numeric ID in here, or the board name you've used in board_types.txt
HAL_CHIBIOS_ARCH_F405 1 | ||
|
||
# board ID for firmware load | ||
APJ_BOARD_ID 1054 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This id is used - need another one
@andyp1per I have addressed the requested changes,Please review the updated PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Tools/AP_Bootloader/board_types.txt
Outdated
@@ -413,6 +413,13 @@ AP_HW_ZeroOne_GNSS 5602 | |||
AP_HW_DroneBuild_G1 5700 | |||
AP_HW_DroneBuild_G2 5701 | |||
|
|||
#IDs 5700-5710 reserved for DroneBuild | |||
AP_HW_DroneBuild_G1 5700 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a dup of the two lines above please remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sry,now that I've changed it,please review
Add DroneerF405 board from Droneer UAV