-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Actions Workflow to build and (unit-)test Audiveris #665
Conversation
Sorry for this late answer, I was away from my laptop the last couple of weeks. Could you modify your PR so that we can merge it into "development" branch. Because we don't develop in "master" but in "development". See our Wiki article. This being said, I'm not familiar with "GitHub Actions workflow". I'm right now googling on it, but perhaps you could shed your own light on this? |
Hi @hbitteur, I fixed the target branch.
The whole workflow will fail if any step (e.g. build or test execution) fails. This can be used to easily see if some functionality broke in a commit. That might especially be useful for regression tests (#563 ) You can see what it looks like on my fork of the repository: https://github.com/PeterGreth/audiveris/actions/workflows/build-and-test.yml
You not only see the executions on that page, but also on every commit and in every PR (see this PR on my fork): I hope that helps. Feel free to ask if anything is unclear |
@PeterGreth Keep in mind that the current Audiveris unit tests are just that: UNIT tests. In other words, they are far from being integration tests. I remember we had a similar discussion last year, about the "number of recognized items" as a quality measurement. But thanks to your work, we now have a framework in place. Let's try to use it as efficiently as possible. Reading your PR content, I noticed (please correct me if I'm wrong):
Thanks, |
The workflow already includes loading of trained tesseract ocr data for future integration tests.
Feedback welcome!