-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fixes for flatpak build #741
Draft
mwilck
wants to merge
24
commits into
Audiveris:development
Choose a base branch
from
mwilck:development
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+755
−389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwilck
force-pushed
the
development
branch
6 times, most recently
from
September 29, 2024 10:56
0233d01
to
8145078
Compare
Don't try to build the flatpak files while in flatpak.
The build result is not always "Audiveris-$version.tar". I am observing "app-$VERSION".tar. Let's just use any .tar file, there will be just one.
Otherwise the flatpak-gradle-generator plugin is not found in the flatpak environment.
Update the submodule to incorporate the changes made for flatpak-gradle-generator support.
…nerator" This can be reverted when we've merged the flathub repository.
…expected config location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Hervé
I've been trying to make the :flatpak:buildFlatpak work, so far without success.
This PR (DRAFT DRAFT, don't apply as-is) shows some of the fixes I made.
It's well possible that some of the commits are wrong. But I couldn't figure out better ways to overcome the various errors I encountered.
Feel free to ask back what I was trying to fix with the individual commits. I'll try to explain.
The last issue I encountered is that gradle (in the flatpak environment) doesn't find all dependencies for the schemas. It seems that
schemas/build.gradle
would also need aflatpakGradleGenerator
task, and that this needs to be properly pulled in byflatpak/build.gradle
. But that exceeds my basically non-existing gradle knowledge by far.