[Breaking] Use CommandManager from Labs #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should wait for 12.0 or at least 11.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avalonia.Labs now has CommandManager with RoutedCommand partially ported from this repository and WPF with some extra features.
Old implementation in this repository can be replaced by Labs package.
https://github.com/AvaloniaUI/Avalonia.Labs/releases/tag/11.0.10.1
Note: it's a huge binary breaking change for anybody, who referenced routed command, and source breaking change for these who used routed command.
If merged, then only when we ready to do such changes.