Add option to insert completion item on PointerPressed/PointerReleased/DoubleTapped #451
+143
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgarstenauer
force-pushed
the
completion-accept-action
branch
from
ac3e2bc to
8eb3f4f
Compare
maxkatz6
reviewed
Dec 16, 2024
| /// <summary> | ||
| /// Defines the pointer action used to request the insertion of a completion item. | ||
| /// </summary> | ||
| public enum CompletionAcceptAction |
There was a problem hiding this comment.
Feels like it could be a flags enum, with a possibility to set None option at least.
There was a problem hiding this comment.
The current options PointerPressed/PointerReleased/DoubleTapped are mutually exclusive and can't be combined as flags.
I am not sure if we want to allow None. That would prevent users from using the mouse for insertions. I suggest to only add None if there is practical use case.
The current defaults (TextEditorOptions.CompletionAcceptAction == CompletionAcceptAction.PointerPressed) ensure that the behavior in existing apps is unchanged.
mgarstenauer
force-pushed
the
completion-accept-action
branch
from
8eb3f4f to
e0f0ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an options to choose whether completion items are inserted on
PointerPressed,PointerReleasedorDoubleTapped.This is an improvement on #414 and addresses the feedback by @gebodal mentioned on issue #413.
In addition, this fixes an issue where first click in the
CompletionWindowis swallowed by thePopupWithCustomPositiontooltip.