-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and simplify handling of single quotes in module completions #15913
Open
StephenWeatherford
wants to merge
2
commits into
main
Choose a base branch
from
sw/refactor-completions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+152
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenWeatherford
force-pushed
the
sw/refactor-completions
branch
from
December 20, 2024 22:14
59c39e4
to
9ba8d1e
Compare
Test this change out locally with the following install scripts (Action run 12440014640) VSCode
Azure CLI
|
Dotnet Test Results 78 files - 39 78 suites - 39 31m 13s ⏱️ - 16m 34s Results for commit 9e6677c. ± Comparison against base commit 81e0d13. This pull request removes 1848 and adds 638 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
StephenWeatherford
force-pushed
the
sw/refactor-completions
branch
from
December 20, 2024 22:51
4287fc1
to
2342696
Compare
StephenWeatherford
changed the title
Simplify handling of single quotes in module completions
Refactor, and simplify handling of single quotes in module completions
Dec 20, 2024
StephenWeatherford
changed the title
Refactor, and simplify handling of single quotes in module completions
Refactor and simplify handling of single quotes in module completions
Dec 20, 2024
StephenWeatherford
force-pushed
the
sw/refactor-completions
branch
from
December 20, 2024 22:59
2342696
to
cca9277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow
There's still a lot that could be done to simplify this file