Reduce how much code requires tokio_async to compile #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, almost no code would have to care about async vs sync, or whether the executor is tokio or something else.
This may be a impractical goal, but it would certainly be nice.
I noticed that some bits of the sync module do not require tokio_async, and may be useful to me implementing a safe synchronous (from the Rust language feature perspective, anyway) version of BeginGetProperty et cetera (see issue
#98 ).
Whether such a sync API is useful to mssf_core, I'm not sure, but right now, my particular use case does not need tokio here, and it's a heavy dependency.
Reorganize code to address some TODOs and increase how much of the code can compile without tokio.