-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ember upgrade #153
Open
josex2r
wants to merge
25
commits into
master
Choose a base branch
from
feature/ember-upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d5bec8f
feat: wait until modal is destroyed
next-joserepresa e1ce8f5
docs: update README
next-joserepresa d4d6687
test: fix coverage
next-joserepresa d575196
feat: upgrade Ember version v3.21.2...v3.28.4
next-joserepresa 32f9fb8
style: prettier
next-joserepresa 49a8d69
style: test prettier rules
next-joserepresa d9b5963
feat: bound resolve and reject to be called as actions
next-joserepresa 03e8fef
refactor(db-254623): more Octane upgrades
next-joserepresa b813884
ci(db-254623): github actions and upgrade husky hooks
next-joserepresa d1f5fae
ci(db-254623): upgrade husky version
josex2r 32a1e96
feat: remove deprecations by upgrading babel
josex2r 604a3cd
Merge remote-tracking branch 'origin/master' into feature/ember-upgrade
josex2r eda7cfa
test: remove runloop functions
josex2r c16d5fd
feat: upgrade ember-auto-import to v2
josex2r f6d262a
feat(octane): migrate to Glimmer components
josex2r c9be982
feat(octane): remove deprecation by using component class instead of …
josex2r 1673529
feat: upgrade ember-task-scheduler
josex2r fa52cdb
feat: add test-waiters to deps to work with ember-embroider-safe
josex2r 7b0cd04
feat: wait close animation to change promise state
josex2r 1377735
feat: move test-waiters to deps
josex2r fe36e11
test: do not wait for click
josex2r 9a64965
feat: remove ember-task-scheduler
josex2r 31d319b
fix: update DOM when closing modal via service
josex2r 4ebec8f
refactor: add some PR #153 suggestions
josex2r 45448aa
Merge remote-tracking branch 'origin/master' into feature/ember-upgrade
josex2r File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module.exports = { | ||
extends: ['@commitlint/config-conventional'] | ||
extends: ['@commitlint/config-conventional'], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,8 @@ | |
# misc | ||
/coverage/ | ||
!.* | ||
.*/ | ||
.eslintcache | ||
|
||
# ember-try | ||
/.node_modules.ember-try/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,53 @@ | ||
module.exports = { | ||
root: true, | ||
parser: 'babel-eslint', | ||
parserOptions: { | ||
ecmaVersion: 2018, | ||
sourceType: 'module', | ||
ecmaFeatures: { | ||
legacyDecorators: true | ||
} | ||
}, | ||
plugins: [ | ||
'ember', | ||
'bbva' | ||
], | ||
extends: [ | ||
'eslint:recommended', | ||
'plugin:ember/recommended', | ||
'eslint-config-bbva' | ||
], | ||
env: { | ||
browser: true | ||
}, | ||
rules: { | ||
'ember/no-jquery': 'error' | ||
}, | ||
overrides: [{ | ||
files: [ | ||
'.huskyrc.js', | ||
'.commitlintrc.js', | ||
'.eslintrc.js', | ||
'.template-lintrc.js', | ||
'ember-cli-build.js', | ||
'index.js', | ||
'testem.js', | ||
'blueprints/*/index.js', | ||
'config/**/*.js', | ||
'tests/dummy/config/**/*.js' | ||
], | ||
excludedFiles: [ | ||
'addon/**', | ||
'addon-test-support/**', | ||
'app/**', | ||
'tests/dummy/app/**' | ||
], | ||
parserOptions: { | ||
sourceType: 'script' | ||
}, | ||
env: { | ||
browser: false, | ||
node: true | ||
}, | ||
plugins: ['node'], | ||
extends: ['plugin:node/recommended'], | ||
rules: { | ||
'no-process-env': 0 | ||
} | ||
}] | ||
root: true, | ||
parser: 'babel-eslint', | ||
parserOptions: { | ||
ecmaVersion: 2018, | ||
sourceType: 'module', | ||
ecmaFeatures: { | ||
legacyDecorators: true, | ||
}, | ||
}, | ||
plugins: ['ember'], | ||
extends: [ | ||
'eslint:recommended', | ||
'plugin:ember/recommended', | ||
'plugin:prettier/recommended', | ||
], | ||
env: { | ||
browser: true, | ||
}, | ||
overrides: [ | ||
// node files | ||
{ | ||
files: [ | ||
'./.commitlintrc.js', | ||
'./.eslintrc.js', | ||
'./.huskyrc.js', | ||
'./.prettierrc.js', | ||
'./.template-lintrc.js', | ||
'./ember-cli-build.js', | ||
'./index.js', | ||
'./testem.js', | ||
'./blueprints/*/index.js', | ||
'./config/**/*.js', | ||
'./tests/dummy/config/**/*.js', | ||
'./tests/.eslintrc.js', | ||
], | ||
parserOptions: { | ||
sourceType: 'script', | ||
}, | ||
env: { | ||
browser: false, | ||
node: true, | ||
}, | ||
plugins: ['node'], | ||
extends: ['plugin:node/recommended'], | ||
}, | ||
{ | ||
// Test files: | ||
files: ['tests/**/*-test.{js,ts}'], | ||
extends: ['plugin:qunit/recommended'], | ||
}, | ||
], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
name: CI | ||
on: [push, pull_request] | ||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
name: Test | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
- name: Set up node | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: 12 | ||
cache: yarn | ||
- name: Install dependencies | ||
run: yarn install | ||
- name: Test | ||
run: yarn test | ||
- name: Release dry-run | ||
run: yarn test:release | ||
env: | ||
GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
- name: Upload codecov | ||
uses: codecov/codecov-action@v1 | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
files: ./coverage/lcov.info | ||
fail_ci_if_error: true | ||
regression: | ||
if: github.ref != 'refs/heads/master' | ||
needs: test | ||
runs-on: ubuntu-latest | ||
name: Regression test - ${{ matrix.ember_try_scenario }} - Experimental ${{ matrix.experimental }} | ||
strategy: | ||
matrix: | ||
ember_try_scenario: | ||
- ember-lts-3.20 | ||
- ember-lts-3.24 | ||
- ember-release | ||
- ember-beta | ||
- ember-default-with-jquery | ||
- ember-classic | ||
- embroider-safe | ||
- embroider-optimized | ||
experimental: [false] | ||
include: | ||
- ember_try_scenario: ember-canary | ||
experimental: true | ||
continue-on-error: ${{ matrix.experimental }} | ||
timeout-minutes: 5 | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
- name: Set up node | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: 12 | ||
cache: yarn | ||
- name: Install dependencies | ||
run: yarn install | ||
- name: Test | ||
run: yarn ember try:one ${{ matrix.ember_try_scenario }} | ||
release: | ||
if: github.ref == 'refs/heads/master' | ||
needs: [test] | ||
runs-on: ubuntu-latest | ||
name: Release | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
token: ${{ secrets.GH_TOKEN }} | ||
- name: Set up node | ||
uses: actions/setup-node@v2 | ||
with: | ||
node-version: 12 | ||
registry-url: 'https://registry.npmjs.org' | ||
- name: Configure CI Git User | ||
run: | | ||
git config --global user.email [email protected] | ||
git config --global user.name adrigzr | ||
- name: Install dependencies | ||
run: yarn install | ||
- name: Release | ||
run: yarn semantic-release | ||
env: | ||
HUSKY: 0 | ||
GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||
NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
yarn commitlint --edit "$1" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
yarn lint-staged |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
#!/bin/sh | ||
. "$(dirname "$0")/_/husky.sh" | ||
|
||
yarn test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module.exports = { | ||
hooks: { | ||
'commit-msg': 'commitlint -E HUSKY_GIT_PARAMS', | ||
'pre-push': 'yarn test' | ||
} | ||
hooks: { | ||
'commit-msg': 'commitlint -E HUSKY_GIT_PARAMS', | ||
'pre-push': 'yarn test', | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
# unconventional js | ||
/blueprints/*/files/ | ||
/vendor/ | ||
|
||
# compiled output | ||
/dist/ | ||
/tmp/ | ||
|
||
# dependencies | ||
/bower_components/ | ||
/node_modules/ | ||
|
||
# misc | ||
/coverage/ | ||
/.nyc_output/ | ||
!.* | ||
.eslintcache | ||
*.html | ||
*.hbs | ||
|
||
# ember-try | ||
/.node_modules.ember-try/ | ||
/bower.json.ember-try | ||
/package.json.ember-try |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
singleQuote: true, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,5 @@ | ||
'use strict'; | ||
|
||
module.exports = { | ||
extends: 'octane', | ||
rules: { | ||
'no-bare-strings': true, | ||
'block-indentation': 'tab', | ||
'no-html-comments': true, | ||
'no-nested-interactive': true, | ||
'self-closing-void-elements': true, | ||
'no-triple-curlies': true, | ||
'deprecated-each-syntax': true, | ||
'link-rel-noopener': true, | ||
'no-invalid-interactive': true, | ||
'require-valid-alt-text': true, | ||
'style-concatenation': true, | ||
'deprecated-inline-view-helper': true, | ||
'no-unused-block-params': true, | ||
'inline-link-to': true, | ||
'no-inline-styles': true, | ||
'simple-unless': false | ||
}, | ||
ignore: [ | ||
'tests/dummy/**' | ||
] | ||
extends: 'recommended', | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsconfig.json
probably should be kept as it should not be published to npm