PSBT support for deterministic bitcoin commitments (tapret and opret) #9

dr-orlovsky · 2023-12-17T15:09:18Z

Finally completed the work on doing everything necessary for DBCs and MPCs in PSBTs. This is prerequisite for completing RGB support in PSBT and last bit of RGB wallet functionality

codecov · 2023-12-17T15:12:18Z

Codecov Report

Attention: 474 lines in your changes are missing coverage. Please review.

Comparison is base (a200597) 52.7% compared to head (45841a7) 0.0%.

❗ Current head 45841a7 differs from pull request most recent head fe14cda. Consider uploading reports for the commit fe14cda to get more accurate results

Files	Patch %	Lines
psbt/src/csval/mpc.rs	0.0%	140 Missing ⚠️
psbt/src/data.rs	0.0%	76 Missing ⚠️
psbt/src/csval/tapret.rs	0.0%	75 Missing ⚠️
psbt/src/csval/opret.rs	0.0%	50 Missing ⚠️
psbt/src/maps.rs	0.0%	49 Missing ⚠️
psbt/src/csval/dbc.rs	0.0%	45 Missing ⚠️
derive/src/taptree.rs	0.0%	16 Missing ⚠️
derive/src/path.rs	0.0%	14 Missing ⚠️
derive/src/derive.rs	0.0%	6 Missing ⚠️
psbt/src/coders.rs	0.0%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master     #9      +/-   ##
========================================
- Coverage    52.7%   0.0%   -52.7%     
========================================
  Files          20     17       -3     
  Lines        2849   3143     +294     
========================================
- Hits         1501      0    -1501     
- Misses       1348   3143    +1795

Flag	Coverage Δ
rust	`0.0% <0.0%> (-52.7%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cryptoquick

Can you check to see if these changes affect the ~250,000 MPC contract limit?

cryptoquick · 2023-12-17T16:26:14Z

derive/src/taptree.rs

@@ -112,6 +120,13 @@ impl<'a> IntoIterator for &'a TapTree {
 }

 impl TapTree {
+    pub fn with_single_leaf(leaf: impl Into<LeafScript>) -> TapTree {
+        Self(vec![LeafInfo {
+            depth: u7::ZERO,


This is really a u7?

Yes, since taptree can have up to 127 levels (and up to 2^127 leafs)

cryptoquick · 2023-12-17T16:26:47Z

derive/src/taptree.rs

+    pub fn with_capacity(capacity: usize) -> Self {
+        Self {
+            leafs: Vec::with_capacity(capacity),
+            buoy: zero!(),


What is buoy?

A helper structure that assists in constructing and merging merkle trees

https://github.com/LNP-BP/client_side_validation/blob/08ef1beccac4a833a72264c4047516728f6b2337/commit_verify/src/merkle.rs#L212-L266

dr-orlovsky · 2023-12-17T17:06:58Z

Can you check to see if these changes affect the ~250,000 MPC contract limit?

I will, but I do not see in any way how they can be affected by this code. It is BP library, not RGB, it has nothing to do with contracts. It just follows Bitcoin consensus and BIPs - that's it

dr-orlovsky · 2023-12-17T17:10:49Z

I will, but I do not see in any way how they can be affected by this code. It is BP library, not RGB, it has nothing to do with contracts. It just follows Bitcoin consensus and BIPs - that's it

Sorry, wrong repo. Yes, the part you commented on is about DBCs and thus related to RGB contracts. But there is nothing which can affect it since the work is done in commit_verify repository and not here. We can't restrict it to the level of a standard library, it doesn't deal with the concept of the validity of commitments and trees and is just a helper tool to construct them (there can be more different tools in the future).

It is like libwally can't restrict the way Bitcoin consensus works

cryptoquick · 2023-12-17T17:23:09Z

I see. This is high level and wouldn't affect consensus beyond what's specified in this library. I think I'm also confused, thank you for the clarification.

cryptoquick

All questions addressed.

ACK

crisdut · 2023-12-18T02:15:48Z

psbt/src/csval/tapret.rs

+    /// the value of tapret commitment has invalid length.
+    InvalidCommitment,
+
+    /// Using non-empty taptree is not supported in RGB v0.10. Please update.


Does this prerequisite remain in later versions?

Suggested change

/// Using non-empty taptree is not supported in RGB v0.10. Please update.

/// Using non-empty taptree is not supported in RGB v0.10 or later. Please update.

Maybe "is not yet supported" without a specific version? At the end this is not even an RGB library...

Yes, does make sense.

We will revisit this topic when we support script-path spend, right?

Yes. This should be done right after v0.11 release. For now I just wanted to save time and do this non-trivial thing later when we have at least basic functionality working.

Yes. This should be done right after v0.11 release. For now I just wanted to save time and do this non-trivial thing later when we have at least basic functionality working.

Yes, I agree with you, better focus on this topic later, because the rgb v0.11 topic is the epic of epics =)

dr-orlovsky added 4 commits December 2, 2023 19:12

chore: refactor independent invoice and derive crates

664fa95

descriptor: introduce dust limits

606be2f

psbt: add more input/output accessor methods

04dc07f

psbt: DBC commitment workflow

c14bae3

dr-orlovsky requested review from cryptoquick, crisdut and zoedberg December 17, 2023 15:09

cryptoquick reviewed Dec 17, 2023

View reviewed changes

cryptoquick approved these changes Dec 18, 2023

View reviewed changes

crisdut approved these changes Dec 18, 2023

View reviewed changes

dr-orlovsky added 6 commits December 18, 2023 18:21

pbst: make KeyAlreadyPresent inner data public

64dc394

chore: export UnsignedTx types

3639022

psbt: impl strict encoding for UnsignedTx

49fea91

derive: support merkle root production for a single-leaf tap trees

4a234b9

psbt: add Psbt::sort_outputs_by method

358faf0

psbt: fix feature-gated import

6649ca2

crisdut approved these changes Dec 25, 2023

View reviewed changes

dr-orlovsky added 9 commits December 25, 2023 15:19

psbt: allow custom keychains in constructing change output

b449ccb

psbt: add dbc_output methods

d70f746

derive: make DerivedScript::Taproot requiring TapTree

1c1ef60

derive, psbt: add method for finding terminal derivation

42d67ef

psbt: store whole TapretCommitment (not just mpc::Commitment)

5d09334

psbt: fix error description

cab0c9c

chore: fix clippy lints

00f8711

ci: fix client-side-validation feature

89b9a2d

release v0.11.0-beta.3

fe14cda

dr-orlovsky force-pushed the v0.11 branch from 45841a7 to fe14cda Compare December 25, 2023 20:01

dr-orlovsky merged commit 584a361 into master Dec 25, 2023
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PSBT support for deterministic bitcoin commitments (tapret and opret) #9

PSBT support for deterministic bitcoin commitments (tapret and opret) #9

dr-orlovsky commented Dec 17, 2023

codecov bot commented Dec 17, 2023 •

edited

Loading

cryptoquick left a comment

cryptoquick Dec 17, 2023

dr-orlovsky Dec 17, 2023

cryptoquick Dec 17, 2023

dr-orlovsky Dec 17, 2023

dr-orlovsky commented Dec 17, 2023

dr-orlovsky commented Dec 17, 2023

cryptoquick commented Dec 17, 2023

cryptoquick left a comment

crisdut Dec 18, 2023

dr-orlovsky Dec 18, 2023

crisdut Dec 18, 2023 •

edited

Loading

dr-orlovsky Dec 18, 2023

crisdut Dec 18, 2023

	/// Using non-empty taptree is not supported in RGB v0.10. Please update.
	/// Using non-empty taptree is not supported in RGB v0.10 or later. Please update.

PSBT support for deterministic bitcoin commitments (tapret and opret) #9

PSBT support for deterministic bitcoin commitments (tapret and opret) #9

Conversation

dr-orlovsky commented Dec 17, 2023

codecov bot commented Dec 17, 2023 • edited Loading

Codecov Report

cryptoquick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dr-orlovsky commented Dec 17, 2023

dr-orlovsky commented Dec 17, 2023

cryptoquick commented Dec 17, 2023

cryptoquick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crisdut Dec 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Dec 17, 2023 •

edited

Loading

crisdut Dec 18, 2023 •

edited

Loading