fix(docker-compose): fix volumes paths for rabbitmq #5
Conversation
when run on MacOS Updates character classes used in random string generation filter
|
Addresses issue #4 |
|
Hi @bcdady, thanks for the PR! We will try to take a look at this, but it's not a priority right now. We were able to successfully setup a new self-hosted customer this week using the current |
| # accommodate different behavior by `sed` on MacOS | ||
| SPACER="" | ||
| if [[ "$OSTYPE" == "darwin"* ]]; then | ||
| SPACER="''" | ||
| fi | ||
|
|
||
| sed -i $SPACER "s/JWT_KEY=.*$/JWT_KEY=$JWTKEY/" docker.env | ||
| sed -i $SPACER "s/CRYPTO_KEY=.*$/CRYPTO_KEY=$CRYPTOKEY/" docker.env | ||
| sed -i $SPACER "s/POSTGRES_PASSWORD=.*$/POSTGRES_PASSWORD=$POSTGRESPASSWORD/" docker.env |
That could be. Since I already have docker (podman) and docker-compose setup on my dev machine, I didn't need or want to redownload via the setup scripts. |
There are quite a few releases of docker-compose CLI available since the version specified in the script (1.29). Why is the setup script pinned to such a seemingly far backdated version/tag? |
| volumes: | ||
| - rabbitmq-data/:/var/lib/rabbitmq/ | ||
| - rabbitmq-logs/:/var/log/rabbitmq | ||
| - rabbitmq-data:/var/lib/rabbitmq/ |
There was a problem hiding this comment.
This is the most essential part of the fix, to play nice with more recent versions of docker-compose.
We provide the |
We simply haven't gotten around to upgrading to a newer version. |
Also makes docker_setup.sh compatible to run on MacOS (for development)