Retry CSS asset loading #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APB9785
reviewed
Jan 3, 2025
Comment on lines
+82
to
+84
| # retry once if not found | ||
| Beacon.Loader.load_runtime_css(site) | ||
| get_current_hash(site) |
There was a problem hiding this comment.
in the case of double-failure, this will return nil instead of previously "". this is probably OK but just noting the change
There was a problem hiding this comment.
I just changed RuntimeJS to return nil as well and either nil or "" will generate the same path.
APB9785
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.