Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile alphabet.cpp #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

xusailor
Copy link

In order to support the arm platform,the above code has been added.

@junaruga
Copy link

I faced this alphabet.cpp's error that prevents bowtie to be built with Fedora, gcc 10 & CPU architectures: aarch64 (arm64), s390x, ppc64le.

The -Wnarrowing is actually a build error on the environments.

alphabet.cpp:293:1: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ inside { } [-Wnarrowing]

This is a backport from bowtie2 commit: BenLangmead/bowtie2@c619b9a .

And we need to fix alphabet.h too.

@junaruga
Copy link

Note: I sent PR to enable aarch64, s390x, ppc64le #102 .

@junaruga junaruga mentioned this pull request Feb 28, 2020
@ch4rr0
Copy link
Collaborator

ch4rr0 commented Jul 17, 2020

Thanks for submitting this pull request, Jun. We already made a similar change to the codebase in the bug_fixes branch. Feel free to check out the changes we have on there.

@junaruga
Copy link

Thanks for the fixing!
@xusailor you can close this PR. This PR was merged as the commit: 8a6d6ca . You can also try to use the released bowtie 1.3.0 aarch64 (arm64) binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants