#2611: make LSP config available synchronously #2676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for review and comment. It is preparation for fixing #2611.
What has changed?
lsp.api.getCljFmtConfig(client)
is cached (forever) (cached once, covering all documents), in order for synchronous Paredit commands to use the format config - or in other words, to enable Paredit commands to be made synchronous and more reliable even if they want to refer to formatter config, which heretofore is async.indentPosition
,formatPositionInfo
, andformatCode
are no longer async.Addressing #2611
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)Updated the[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.Added to or updated docs in this branch, if appropriateTestsTested the particular changenpm run prettier-format
)npm run eslint
before creating your PR, or runnpm run eslint-watch
to eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik