Completed login and signup API endpoints #165
Conversation
There was a problem hiding this comment.
Some of the changes are good while some are questionable, I have commented on them where they're. @BhattAnsh please check them once.
|
|
||
| - Node.js installed | ||
| - MongoDB instance running locally or remotely | ||
| - Postman for API testing |
There was a problem hiding this comment.
Postman is not necessarily needed since you can test API requests multiple ways.
| } | ||
| ``` | ||
|
|
||
| #### Example (Postman): |
There was a problem hiding this comment.
I will wait for @BhattAnsh 's review on this.
There was a problem hiding this comment.
why change the folder structure? I am curious 👀
There was a problem hiding this comment.
This folder structure is a standard approach for organizing backend projects, which helps in maintaining clarity and scalability. If you have any specific suggestions or prefer a different structure, feel free to share them! I'd be happy to adapt to a structure that better suits the team's preferences.
| const router = express.Router(); | ||
|
|
||
| // Correctly typed middleware function | ||
| router.post("/signup", signup); |
There was a problem hiding this comment.
This comment here, // Correctly typed middleware function what was the reason behind this?
There was a problem hiding this comment.
I have provided an example of how to use Postman; that's it.
The folder structure follows the best practices for the backend.
The code is commented for my reference, showing the syntax for middleware, that's all. Comments will help for further development
|
guys if u want to change something , I am ready to do that ... |
|
@srujanGowda08 wait for sometime for the PA to review these changes. We will let you know if any changes are required. In the meantime, please add the video in the description of the PR itself. |
|
Merged. |
|
@srujanGowda08 add the video and mention the issue. |
|
please add me the points thank you |
Closes #163
/auth/signupendpoint for user registration./auth/loginendpoint for user authentication.Video:- https://drive.google.com/file/d/1a6zQEWVKzjijgIdFJ8eCDOAK9mrilTAm/view?usp=sharing
If u want a complete video i will share a video in discard