Integrate ModularTokenizerOp with Hugging Face remote 🤗
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SagiPolaczek
commented
Sep 16, 2024
| @@ -58,7 +58,7 @@ exclude = | |||
|
|
|||
|
|
|||
| [mypy] | |||
| python_version = 3.7 | |||
| python_version = 3.9 | |||
There was a problem hiding this comment.
due mypy pre-commit errors
SagiPolaczek
commented
Sep 16, 2024
Comment on lines
+554
to
+556
| def save_pretrained(self, save_directory: Union[str, Path]) -> None: | ||
| print(f"Saving @ {save_directory=}") | ||
| self._tokenizer.save(path=str(save_directory)) |
There was a problem hiding this comment.
As far as I understand, all of the information is being stored in tokenizer. That's why it's enough to save it.
mosheraboh
reviewed
Sep 18, 2024
| cache_dir: Optional[Union[str, Path]] = None, | ||
| local_files_only: bool = False, | ||
| revision: Optional[str] = None, | ||
| ) -> "ModularTokenizerOp": |
There was a problem hiding this comment.
add a comment that for arguments details directs to snapshot_download
mosheraboh
previously approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting HF-like API to integrate the modular_tokenizer_op with HF remote.
API: