Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of changes to tests to support python3 #1749

Closed
wants to merge 2 commits into from
Closed

Couple of changes to tests to support python3 #1749

wants to merge 2 commits into from

Conversation

iljah
Copy link

@iljah iljah commented Mar 25, 2021

After these changes tests start to complain about things fixed by #1746

@iljah iljah mentioned this pull request Mar 25, 2021
Closed
@g1itch
Copy link
Collaborator

g1itch commented Mar 25, 2021

test_api is irrelevant to python3 because it uses TestProcess. It's skipped in python3 job. There are more warnings related to bytes in travis job log for test_blindsig.

g1itch
g1itch requested changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@g1itch g1itch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes does not affect anything as I can see. It's just minus one test case.

src/tests/test_crypto.py
@@ -73,7 +73,8 @@ class TestCrypto(RIPEMD160TestCase, unittest.TestCase):
"""RIPEMD160 test case for Crypto"""
@staticmethod
def _hashdigest(data):
return RIPEMD.RIPEMD160Hash(data).digest()
from pybitmessage.fallback import RIPEMD160Hash
return RIPEMD160Hash(data).digest()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't get it. This part of the test should use pycrypto or pycryptodome, not fallback. Because it's the test for fallback itself.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment stating this would've been helpful.

@iljah
Copy link
Author

iljah commented Mar 25, 2021

test_api is irrelevant to python3

This get me past complaints when using python3 so looks like it's not irrelevant.

@g1itch
Copy link
Collaborator

g1itch commented Mar 25, 2021

test_api is irrelevant to python3

This get me past complaints when using python3 so looks like it's not irrelevant.

You even didn't bother to read #1712 and trying to edit the code you don't understand ): test_api is skipped here: https://github.com/Bitmessage/PyBitmessage/blob/v0.6/src/tests/test_process.py#L18

@g1itch g1itch closed this Mar 25, 2021
@iljah
Copy link
Author

iljah commented Mar 25, 2021

You even didn't bother to read #1712

I've been aware of it for a while but if you want more specific changes you'll have to provide more specific suggestions.

@iljah
Copy link
Author

iljah commented Mar 25, 2021

trying to edit the code you don't understand

I'm not using skip_python3() event though it's still included here. Same as in #1712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g1itch g1itch g1itch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iljah @g1itch