Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAUSED] Removing dask e2e workaround since cudf issue 7572 was fixed #1431

Open
wants to merge 3 commits into
base: branch-21.06
Choose a base branch
from
+1 −6
Open

[PAUSED] Removing dask e2e workaround since cudf issue 7572 was fixed #1431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51c7080
Removing workaround since cudf issue 7572 was fixed
Apr 5, 2021
db5cb8d
Edit changelog
Apr 5, 2021
433385d
Fix
Apr 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- #1331 Added flag to enable null e2e testing
- #1418 Adding support for docker image
- #1419 Added concat cache machine timeout
- #1431 Removed dask_cudf e2e workaround since cudf issue 7572 was already fixed

## Bug Fixes
- #1335 Fixing uninitialized var in orc metadata and handling the parseMetadata exceptions properly
Expand Down
6 changes: 0 additions & 6 deletions tests/BlazingSQLTest/Utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,6 @@ def test_name(queryType, fileSchemaType):
def skip_test(dask_client, nRals, fileSchemaType, queryType):
testsWithNulls = Settings.data["RunSettings"]["testsWithNulls"]

if fileSchemaType == DataType.DASK_CUDF:
# Skipping combination DASK_CUDF and testsWithNulls="true"
# due to https://github.com/rapidsai/cudf/issues/7572
if dask_client is None or testsWithNulls == "true":
return True

if fileSchemaType == DataType.CUDF:
# TODO dask tests percy kharoly c.gonzales
# skip gdf test when we are about to run tests
Expand Down