VersionUpdate #270
Open
VersionUpdate #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General version upgrade to make further updates more convenient -
ubuntu upgraded to 22.04
python upgraded to 3.10.12
fixed issues caused by upgrade :
-> unable to build wheel for greenlet-
fixed by adding version requirement
-> cannot import markup from flask-
fixed by importing markup from markupsafe
-> flask_common issue-
fixed by removing flask_common package as it is deemed redundant (only initialized never used) (confirmed app is working after removal)
-> cannot import lxml html clean-
fixed by adding lxml_html_clean package as module has been added as a seperate one
also removed lxml as only one above package required
-> issue with how data is passed to con.execute() in storage.py
fixed by modifying the code such that data is passed as dictionaries now
-> issue with how fetchall() returns data-
fixed using a small list comprehension that makes it such that the earlier data from fetchall is converted to how it was returned in the past
The updated version has been tested by me to the best of my abilities, please let me know if any other issues persist
Thank you!
@Pavithratrdev, please let me know about this update.