Merge pull request #3445 from BrentOzarULTD/dev

2024-02-22 Release

.github/workflows/integration-tests.yml

@@ -0,0 +1,59 @@
+name: First Responder Kit Integration Tests
+
+on: 
+    push:
+    workflow_dispatch:
+    pull_request:
+        types: [opened, review_requested, synchronize]
+
+jobs:
+  build:
+    name: Build
+    runs-on: ubuntu-latest
+    strategy:
+        matrix:
+            SQL_ENGINE_VERSION: [2017,2019,2022]
+            COLLATION: [SQL_Latin1_General_CP1_CS_AS]
+
+
+    steps:
+        - name: Checkout repository
+          uses: actions/checkout@v4
+
+        - name: Install SqlServer Module
+          shell: pwsh
+          run: |
+              Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
+              Install-Module SqlServer
+  
+        - name: Install SQL Server
+          uses: potatoqualitee/[email protected]
+          with:
+            install: sqlengine
+            version: ${{ matrix.SQL_ENGINE_VERSION }}
+            collation: ${{ matrix.COLLATION }}
+
+        - name: Check SQL Install
+          run: | 
+              sqlcmd -S localhost -U sa -P dbatools.I0 -d tempdb -Q "SELECT @@version as Version;" -I -b -t 60
+              sqlcmd -S localhost -U sa -P dbatools.I0 -d tempdb -Q "SELECT SERVERPROPERTY('Collation') AS Collation;" -I -b -t 60
+
+        - name: Deploy FRK
+          run: | 
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzCache.sql" -I -b -t 60
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzWho.sql" -I -b -t 60
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_Blitz.sql" -I -b -t 60
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzFirst.sql" -I -b -t 60
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzAnalysis.sql" -I -b -t 60
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzBackups.sql" -I -b -t 60      
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzIndex.sql" -I -b -t 60
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzInMemoryOLTP.sql" -I -b -t 60
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzLock.sql" -I -b -t 60
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -i "sp_BlitzQueryStore.sql" -I -b -t 60         
+            sqlcmd -S localhost -U sa -P dbatools.I0 -d master -Q "SELECT * FROM sys.procedures WHERE name LIKE 'sp_Blitz%';" -I -b -t 60
+
+        - name: Run Pester Tests
+          shell: pwsh
+          run: | 
+            cd tests
+            ./run-tests.ps1

CONTRIBUTING.md

@@ -42,6 +42,8 @@ Note that if you're not ready to get started coding in the next week, or if you
 
 We're not picky at all about style, but a few things to know:
 
+Don't touch the files that start with Install, like Install-All-Scripts.sql. Those are dynamically generated. You only have to touch the ones that start with sp_.
+
 Your code needs to compile & run on all currently supported versions of SQL Server. It's okay if functionality degrades, like if not all features are available, but at minimum the code has to compile and run.
 
 Your code must handle:

Deprecated/sp_BlitzIndex_SQL_Server_2005.sql

@@ -43,7 +43,7 @@ Known limitations of this version:
  --		Example 1: index creates use ONLINE=? instead of ONLINE=ON / ONLINE=OFF. This is because it's important for the user to understand if it's going to be offline and not just run a script.
  --		Example 2: they do not include all the options the index may have been created with (padding, compression filegroup/partition scheme etc.)
  --		(The compression and filegroup index create syntax isn't trivial because it's set at the partition level and isn't trivial to code. Two people have voted for wanting it so far.)
- - Doesn't advise you about data modeling for clustered indexes and primary keys (primarily looks for signs of insanity.)
+ - Doesn't advise you about data modeling for clustered indexes and primary keys (primarily looks for signs of problems.)
  - Found something? Let us know at [email protected].
 
  Thanks for using sp_BlitzIndex(TM)!