Typescript JSDoc Part 2 - Export custom component types #5141
+128
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
* Only export the type for typescript/jsdoc
awikkerink
force-pushed
the
awikkerink/typescript-add-type-exports
branch
from
2c26bf1 to
001cf6f
Compare
2 tasks
awikkerink
changed the title
awikkerink
changed the title
awikkerink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This step is pretty easy to automate. The tricky part is when too many typedefs are added. A better approach would be to export all of the component types, since it's possible to get the class via
customElements.getCan be merged before Parts 1 and 2, since this is just additive. Merging this first would just change the generated mapping.d.ts