feat: nextjs 15 e2e integration test setup #3772
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7f39ee3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud. |
sidmohanty11
requested review from
samijaber,
kapunahelewong and
a team
as code owners
|
LGTM |
| @@ -44,9 +44,6 @@ const initializeAbTest = async ( | |||
| ) => { | |||
| if (!baseURL) throw new Error('Missing baseURL'); | |||
|
|
|||
| // SSR A/B tests do not seem to work on old NextJS. Likely a config issue. | |||
| test.skip(packageName === 'gen1-next'); | |||
| !window.location.pathname.includes('can-track-false') && | ||
| !window.location.pathname.includes('symbol-tracking') | ||
| ) { | ||
| builder.canTrack = true; |
There was a problem hiding this comment.
only issue is im not sure if this will work on tests that include client-side navigations? This code should only run a single time when the JS is first loaded into the browser.
Just something to keep in mind
There was a problem hiding this comment.
got it, so as canTrack=false tests are only on singular pages we don't face this
## Description https://builder-io.atlassian.net/browse/ENG-7752 _Screenshot_ If relevant, add a screenshot or two of the changes you made.
Description
https://builder-io.atlassian.net/browse/ENG-7752
Screenshot
If relevant, add a screenshot or two of the changes you made.