Skip to content

Commit

Permalink
Fix angular event handling (#2)
Browse files Browse the repository at this point in the history
* wip: remove on from output variables

* remove on also on emit event

* wip on test

* add event child props

* add e2e test

* Event listener e2e test

* clean up

* add changeset
  • Loading branch information
bastiW committed Sep 26, 2024
1 parent ed2abd6 commit a2bd50f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/six-ghosts-exercise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/mitosis': minor
---

Remove on prefix on angulare event emits to be aligned with Angular Style Rule 05-16: Don't Prefix Output Properties
2 changes: 0 additions & 2 deletions packages/core/src/generators/angular/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -877,8 +877,6 @@ export const componentToAngular: TranspilerGenerator<ToAngularOptions> =
return `@Output() ${removeOnFromAngularOutputEvent(outputName)} = new EventEmitter()`;
});

outputs.forEach(console.log);

const domRefs = getRefs(json);
const jsRefs = Object.keys(json.refs).filter((ref) => !domRefs.has(ref));
const componentsUsed = Array.from(getComponentsUsed(json)).filter((item) => {
Expand Down

0 comments on commit a2bd50f

Please sign in to comment.