Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): import paths for child components #1208

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(angular): import paths for child components #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e4b8a7
fix(angular): import paths for child components
sean-perkins Jun 21, 2023
d2928dc
refactor: move DEFAULT_OPTIONS into generator
sean-perkins Jun 22, 2023
b6a05e9
chore: update snapshots
sean-perkins Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 38 additions & 36 deletions packages/core/src/__tests__/__snapshots__/angular.import.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ import { CommonModule } from \\"@angular/common\\";

import { Component, Input } from \\"@angular/core\\";

import MyBooleanAttributeComponent from \\"./basic-boolean-attribute-component.raw\\";
import MyBooleanAttributeComponentModule from \\"./basic-boolean-attribute-component.raw\\";

@Component({
selector: \\"my-boolean-attribute, MyBooleanAttribute\\",
Expand Down Expand Up @@ -386,8 +386,8 @@ import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

import MyBasicOnMountUpdateComponent from \\"./basic-onMount-update.raw\\";
import MyBasicComponent from \\"./basic.raw\\";
import MyBasicOnMountUpdateComponentModule from \\"./basic-onMount-update.raw\\";
import MyBasicComponentModule from \\"./basic.raw\\";

@Component({
selector: \\"my-basic-child-component, MyBasicChildComponent\\",
Expand Down Expand Up @@ -984,7 +984,7 @@ import { Component, ViewChild, ElementRef, Input } from \\"@angular/core\\";

import { Builder, builder } from \\"@builder.io/sdk\\";
import {
BuilderBlock as BuilderBlockComponent,
BuilderBlock as BuilderBlockComponentModule,
BuilderBlocks,
get,
set,
Expand Down Expand Up @@ -1701,7 +1701,7 @@ import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

import ContentSlotCode from \\"./content-slot-jsx.raw\\";
import ContentSlotCodeModule from \\"./content-slot-jsx.raw\\";

@Component({
selector: \\"slot-code, SlotCode\\",
Expand Down Expand Up @@ -1730,7 +1730,7 @@ import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

import ContentSlotCode from \\"./content-slot-jsx.raw\\";
import ContentSlotCodeModule from \\"./content-slot-jsx.raw\\";

@Component({
selector: \\"slot-code, SlotCode\\",
Expand Down Expand Up @@ -2662,7 +2662,7 @@ import { CommonModule } from \\"@angular/common\\";

import { Component, Input } from \\"@angular/core\\";

import RenderBlock from \\"./builder-render-block.raw\\";
import RenderBlockModule from \\"./builder-render-block.raw\\";

@Component({
selector: \\"render-content, RenderContent\\",
Expand Down Expand Up @@ -3272,12 +3272,12 @@ import { getBlockComponentOptions } from \\"../../functions/get-block-component-
import { getBlockProperties } from \\"../../functions/get-block-properties.js\\";
import { getBlockTag } from \\"../../functions/get-block-tag.js\\";
import { getProcessedBlock } from \\"../../functions/get-processed-block.js\\";
import { getReactNativeBlockStyles } from \\"../../functions/get-react-native-block-styles.js\\";
import BlockStyles from \\"./block-styles.lite\\";
import { getReactNativeBlockStylesModule } from \\"../../functions/get-react-native-block-styles.js\\";
import BlockStylesModule from \\"./block-styles.lite\\";
import { isEmptyHtmlElement } from \\"./render-block.helpers.js\\";
import RenderComponentWithContext from \\"./render-component-with-context.lite\\";
import RenderComponent from \\"./render-component.lite\\";
import RenderRepeatedBlock from \\"./render-repeated-block.lite\\";
import RenderRepeatedBlockModule from \\"./render-repeated-block.lite\\";

@Component({
selector: \\"render-block, RenderBlock\\",
Expand Down Expand Up @@ -3527,7 +3527,7 @@ import {
sendComponentsToVisualEditor,
trackClick,
} from \\"@dummy/injection-js\\";
import RenderBlocks from \\"@dummy/RenderBlocks.lite.tsx\\";
import RenderBlocksModule from \\"@dummy/RenderBlocks.lite.tsx\\";

@Component({
selector: \\"render-content, RenderContent\\",
Expand Down Expand Up @@ -3872,7 +3872,7 @@ import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

import Foo from \\"./foo-sub-component.lite\\";
import FooModule from \\"./foo-sub-component.lite\\";

@Component({
selector: \\"sub-component, SubComponent\\",
Expand Down Expand Up @@ -4478,7 +4478,7 @@ type Props = {
type: string;
};

import MyBooleanAttributeComponent from \\"./basic-boolean-attribute-component.raw\\";
import MyBooleanAttributeComponentModule from \\"./basic-boolean-attribute-component.raw\\";

@Component({
selector: \\"my-boolean-attribute, MyBooleanAttribute\\",
Expand Down Expand Up @@ -4521,8 +4521,8 @@ import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

import MyBasicOnMountUpdateComponent from \\"./basic-onMount-update.raw\\";
import MyBasicComponent from \\"./basic.raw\\";
import MyBasicOnMountUpdateComponentModule from \\"./basic-onMount-update.raw\\";
import MyBasicComponentModule from \\"./basic.raw\\";

@Component({
selector: \\"my-basic-child-component, MyBasicChildComponent\\",
Expand Down Expand Up @@ -4905,7 +4905,7 @@ type Props = {
slotTesting: JSX.Element;
};

import type { JSX } from \\"../../../../jsx-runtime\\";
import { JSX } from \\"../../../../jsx-runtime\\";

@Component({
selector: \\"content-slot-code, ContentSlotCode\\",
Expand Down Expand Up @@ -4949,7 +4949,7 @@ const defaultProps = {
slotContent: undefined,
};

import type { JSX } from \\"../../../../jsx-runtime\\";
import { JSX } from \\"../../../../jsx-runtime\\";

@Component({
selector: \\"content-slot-jsx-code, ContentSlotJsxCode\\",
Expand Down Expand Up @@ -5199,7 +5199,7 @@ export type FormState = \\"unsubmitted\\" | \\"sending\\" | \\"success\\" | \\"e

import { Builder, builder, BuilderElement } from \\"@builder.io/sdk\\";
import {
BuilderBlock as BuilderBlockComponent,
BuilderBlock as BuilderBlockComponentModule,
BuilderBlocks,
get,
set,
Expand Down Expand Up @@ -6005,7 +6005,7 @@ type Props = {
[key: string]: string;
};

import ContentSlotCode from \\"./content-slot-jsx.raw\\";
import ContentSlotCodeModule from \\"./content-slot-jsx.raw\\";

@Component({
selector: \\"slot-code, SlotCode\\",
Expand Down Expand Up @@ -6038,7 +6038,7 @@ type Props = {
[key: string]: string;
};

import ContentSlotCode from \\"./content-slot-jsx.raw\\";
import ContentSlotCodeModule from \\"./content-slot-jsx.raw\\";

@Component({
selector: \\"slot-code, SlotCode\\",
Expand Down Expand Up @@ -6714,7 +6714,7 @@ type Props = {
slotTesting: JSX.Element;
};

import type { JSX } from \\"../../../../jsx-runtime\\";
import { JSX } from \\"../../../../jsx-runtime\\";

@Component({
selector: \\"class-name-code, ClassNameCode\\",
Expand Down Expand Up @@ -7080,7 +7080,9 @@ type RenderContentProps = {
};

import { BuilderContent, GetContentOptions } from \\"@builder.io/sdk\\";
import RenderBlock, { RenderBlockProps } from \\"./builder-render-block.raw\\";
import RenderBlockModule, {
RenderBlockModuleProps,
} from \\"./builder-render-block.raw\\";

@Component({
selector: \\"render-content, RenderContent\\",
Expand Down Expand Up @@ -7739,7 +7741,7 @@ export type RenderBlockProps = {
};

import { TARGET } from \\"../../constants/target.js\\";
import type {
import {
BuilderContextInterface,
RegisteredComponent,
} from \\"../../context/types.js\\";
Expand All @@ -7750,16 +7752,16 @@ import { getBlockComponentOptions } from \\"../../functions/get-block-component-
import { getBlockProperties } from \\"../../functions/get-block-properties.js\\";
import { getBlockTag } from \\"../../functions/get-block-tag.js\\";
import { getProcessedBlock } from \\"../../functions/get-processed-block.js\\";
import { getReactNativeBlockStyles } from \\"../../functions/get-react-native-block-styles.js\\";
import type { BuilderBlock } from \\"../../types/builder-block.js\\";
import type { Nullable } from \\"../../types/typescript.js\\";
import BlockStyles from \\"./block-styles.lite\\";
import { getReactNativeBlockStylesModule } from \\"../../functions/get-react-native-block-styles.js\\";
import { BuilderBlock } from \\"../../types/builder-block.js\\";
import { Nullable } from \\"../../types/typescript.js\\";
import BlockStylesModule from \\"./block-styles.lite\\";
import { isEmptyHtmlElement } from \\"./render-block.helpers.js\\";
import RenderComponentWithContext from \\"./render-component-with-context.lite\\";
import type { RenderComponentProps } from \\"./render-component.lite\\";
import { RenderComponentProps } from \\"./render-component.lite\\";
import RenderComponent from \\"./render-component.lite\\";
import RenderRepeatedBlock from \\"./render-repeated-block.lite\\";
import type { RepeatData } from \\"./types.js\\";
import RenderRepeatedBlockModule from \\"./render-repeated-block.lite\\";
import { RepeatData } from \\"./types.js\\";

@Component({
selector: \\"render-block, RenderBlock\\",
Expand Down Expand Up @@ -8017,7 +8019,7 @@ import {
sendComponentsToVisualEditor,
trackClick,
} from \\"@dummy/injection-js\\";
import RenderBlocks from \\"@dummy/RenderBlocks.lite.tsx\\";
import RenderBlocksModule from \\"@dummy/RenderBlocks.lite.tsx\\";

@Component({
selector: \\"render-content, RenderContent\\",
Expand Down Expand Up @@ -8382,7 +8384,7 @@ import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

import Foo from \\"./foo-sub-component.lite\\";
import FooModule from \\"./foo-sub-component.lite\\";

@Component({
selector: \\"sub-component, SubComponent\\",
Expand Down Expand Up @@ -8458,8 +8460,8 @@ export type TypeDependencyProps = {
foo2: Foo2;
};

import type { Foo } from \\"./foo-type\\";
import type { Foo as Foo2 } from \\"./type-export.lite\\";
import { Foo } from \\"./foo-type\\";
import { Foo as Foo2 } from \\"./type-export.lite\\";

@Component({
selector: \\"type-dependency, TypeDependency\\",
Expand Down Expand Up @@ -8916,7 +8918,7 @@ import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

import Button from \\"./Button.lite\\";
import ButtonModule from \\"./Button.lite\\";

@Component({
selector: \\"my-component, MyComponent\\",
Expand Down Expand Up @@ -9445,7 +9447,7 @@ import { CommonModule } from \\"@angular/common\\";

import { Component } from \\"@angular/core\\";

import Button from \\"./Button.lite\\";
import ButtonModule from \\"./Button.lite\\";

@Component({
selector: \\"my-component, MyComponent\\",
Expand Down
Loading