Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pre-commit | Added one unit test #63

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

spirosmaggioros
Copy link
Member

  • Removed unused imports DLMUSE and DLICV from SegmentImage.py.

  • Corrected a typo in the docstring of the merge_output_data function in utils.py.

  • Added type hint Any to the progress_bar parameter in the run_pipeline function in dlmuse_pipeline.py.

  • Added a new test function testing_get_bids_prefix in test_utils.py to validate the get_bids_prefix function.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (976fa36) to head (58dda13).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   71.03%   72.42%   +1.39%     
==========================================
  Files           3        3              
  Lines         290      301      +11     
==========================================
+ Hits          206      218      +12     
+ Misses         84       83       -1     
Files with missing lines Coverage Δ
NiChart_DLMUSE/__init__.py 100.00% <100.00%> (ø)
NiChart_DLMUSE/utils.py 57.36% <100.00%> (+0.52%) ⬆️
tests/test_utils.py 98.18% <100.00%> (+0.20%) ⬆️

@AlexanderGetka-cbica
Copy link
Contributor

Regarding the imports, we should rewrite the run_pipeline, run_dlicv, run_dlmuse methods in this package to directly call the DLMUSE and DLICV packages rather than going through the CLI. This will be useful in the future for more in-depth progress reports, error reporting/handling, and parallelization at the level of these modules

@spirosmaggioros
Copy link
Member Author

Agree. I didn't change kyle's logic so i kept it as is.
Will do this on another branch tomorrow!

@spirosmaggioros
Copy link
Member Author

@AlexanderGetka-cbica I will wait for my PR's at DLMUSE and DLICV to be reviewed/merged before merging this one as i will add the direct api calls for DLMUSE and DLICV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants