-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed pre-commit | Added one unit test #63
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 71.03% 72.42% +1.39%
==========================================
Files 3 3
Lines 290 301 +11
==========================================
+ Hits 206 218 +12
+ Misses 84 83 -1
|
Regarding the imports, we should rewrite the run_pipeline, run_dlicv, run_dlmuse methods in this package to directly call the DLMUSE and DLICV packages rather than going through the CLI. This will be useful in the future for more in-depth progress reports, error reporting/handling, and parallelization at the level of these modules |
Agree. I didn't change kyle's logic so i kept it as is. |
@AlexanderGetka-cbica I will wait for my PR's at DLMUSE and DLICV to be reviewed/merged before merging this one as i will add the direct api calls for DLMUSE and DLICV. |
Removed unused imports
DLMUSE
andDLICV
fromSegmentImage.py
.Corrected a typo in the docstring of the
merge_output_data
function inutils.py
.Added type hint
Any
to theprogress_bar
parameter in therun_pipeline
function indlmuse_pipeline.py
.Added a new test function
testing_get_bids_prefix
intest_utils.py
to validate theget_bids_prefix
function.