Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code formatting improvements #138

Closed
jraddaoui opened this issue Mar 25, 2019 · 1 comment
Closed

Code formatting improvements #138

jraddaoui opened this issue Mar 25, 2019 · 1 comment
Assignees
Milestone

Comments

@jraddaoui
Copy link
Collaborator

jraddaoui commented Mar 25, 2019

A few enhancements suggested along the way:

  • Add proper names to mocked functions on tests.
  • Move static variables to class attributes in tests.
  • Properly format doc-strings in the project.
  • Use black for auto-formatting.
@sallain sallain added this to the phase2 milestone Mar 27, 2019
@jraddaoui jraddaoui self-assigned this Apr 4, 2019
@jraddaoui
Copy link
Collaborator Author

Hi @stefanabreitwieser,

This were just some "minor" changes to improve the code quality of the project and the CI checks related to that. I've created #147 to add some notes about this in the contributing file alongside other improvements that are needed in there, but I think this one could be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants