Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code formatting #148

Merged
merged 5 commits into from
Apr 4, 2019
Merged

Improve code formatting #148

merged 5 commits into from
Apr 4, 2019

Conversation

jraddaoui
Copy link
Collaborator

@jraddaoui jraddaoui commented Apr 4, 2019

  • Set up black.
  • Fix linting issues.
  • Give meaningful names to mocked functions in tests.
  • Move static vars to class attributes in tests.
  • Fix docstrings.

Connects to #138.

There are some things still to do if we have the time later, reflected in #67 and #147.

@jraddaoui jraddaoui self-assigned this Apr 4, 2019
@jraddaoui jraddaoui requested a review from cole April 4, 2019 15:32
@jraddaoui jraddaoui requested a review from sevein April 4, 2019 15:32
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is 85.92%.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files          24       24           
  Lines        1074     1074           
=======================================
  Hits          917      917           
  Misses        157      157
Impacted Files Coverage Δ
scope/urls.py 100% <ø> (ø) ⬆️
dips/migrations/0001_initial.py 100% <ø> (ø) ⬆️
dips/helpers.py 100% <100%> (ø) ⬆️
dips/templatetags/custom_tags.py 100% <100%> (ø) ⬆️
scope/__init__.py 100% <100%> (ø) ⬆️
dips/models.py 98.64% <100%> (ø) ⬆️
scope/staticfiles.py 100% <100%> (ø) ⬆️
dips/handlers.py 100% <100%> (ø) ⬆️
.../migrations/0003_alter_digitalfile_datemodified.py 100% <100%> (ø) ⬆️
search/helpers.py 100% <100%> (ø) ⬆️
... and 13 more

Copy link
Collaborator

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@jraddaoui jraddaoui merged commit 4d25c0f into master Apr 4, 2019
@jraddaoui jraddaoui removed the review label Apr 4, 2019
@jraddaoui jraddaoui deleted the ev/issue-138-formatting branch April 4, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants