Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polygon repair using union and intersection #8510

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Polygon repair using union and intersection #8510

wants to merge 50 commits into from

Conversation

sloriot
Copy link
Member

@sloriot sloriot commented Oct 1, 2024 •
edited
Loading

Summary of Changes

Add new repair rules in Polygon_repair package

Release Management

  • Affected package(s): Polygon_repair
  • Feature/Small Feature (if any): link -- pre-approval 25/01/03
  • Link to compiled documentation: link
  • License and copyright ownership: GF

This was referenced Oct 1, 2024
Closed
Closed
@afabri afabri self-assigned this Oct 21, 2024
@afabri afabri added this to the 6.1-beta milestone Oct 21, 2024
@sloriot sloriot changed the base branch from master to 5.5.x-branch October 21, 2024 17:25
@sloriot sloriot changed the base branch from 5.5.x-branch to master October 21, 2024 17:25
@afabri

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@afabri

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@afabri

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8510/v1/Manual/index.html

@afabri
Copy link
Member

afabri commented Dec 10, 2024

/force-build:v1

@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8510/v1/Manual/index.html

@afabri
Copy link
Member

afabri commented Dec 10, 2024

/force-build:v1

@github-actions GitHub Actions
Copy link

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8510/v1/Manual/index.html

@MaelRL MaelRL added Not yet approved The feature or pull-request has not yet been approved. CHANGES.md not updated labels Dec 10, 2024
sloriot
sloriot commented Dec 18, 2024
View reviewed changes
Polygon_repair/doc/Polygon_repair/Polygon_repair.txt

Broadly, the algorithm consists of three steps:
\cgalFigureBegin{WindingNonZeroDifferent, WindingNonZeroDifferent.svg}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the light grey for the color of the contour mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It allows to visually disambiguate polygons that intersect.

@sloriot
Copy link
Member Author

sloriot commented Dec 18, 2024

I'm not sure it's a good idea to no longer have this picture in the doc.

@sloriot
Copy link
Member Author

sloriot commented Dec 23, 2024

Successfully tested in CGAL-6.1-Ic-45

@afabri
Copy link
Member

afabri commented Jan 2, 2025

I'm not sure it's a good idea to no longer have this picture in the doc.

I don't see a big benefit from the figure. In case we kept it, we have to add how it looks for the non-zero rule.

@sloriot
Copy link
Member Author

sloriot commented Jan 3, 2025

/force-build:v1

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/8510/v1/Manual/index.html

@sloriot sloriot added Under Testing pre-approved For pre-approved small features. After 15 days the feature will be accepted. labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afabri afabri afabri left review comments

Assignees

@afabri afabri

Labels
Enhancement Not yet approved The feature or pull-request has not yet been approved. Pkg::Polygon_repair pre-approved For pre-approved small features. After 15 days the feature will be accepted. Small feature TODO (web) Under Testing
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
3 participants
@sloriot @afabri @MaelRL