Skip to content

Commit

Permalink
fix: Revert to DrawBorderSettings::Default on Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
richiemcilroy committed Aug 1, 2024
1 parent 1844a0c commit fa776e0
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/capturer/engine/win/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,11 @@ pub fn create_capturer(options: &Options, tx: mpsc::Sender<Frame>) -> WCStream {
false => CursorCaptureSettings::WithoutCursor,
};

let show_highlight = match options.show_highlight {
true => DrawBorderSettings::WithBorder,
false => DrawBorderSettings::WithoutBorder,
};

let settings = match target {
Target::Display(display) => Settings::Display(WCSettings::new(
WCMonitor::from_raw_hmonitor(display.raw_handle.0),
show_cursor,
show_highlight,
DrawBorderSettings::Default,
color_format,
FlagStruct {
tx,
Expand All @@ -170,7 +165,7 @@ pub fn create_capturer(options: &Options, tx: mpsc::Sender<Frame>) -> WCStream {
Target::Window(window) => Settings::Window(WCSettings::new(
WCWindow::from_raw_hwnd(window.raw_handle.0),
show_cursor,
show_highlight,
DrawBorderSettings::Default,
color_format,
FlagStruct {
tx,
Expand Down

1 comment on commit fa776e0

@Kyu
Copy link

@Kyu Kyu commented on fa776e0 Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw: according to the lib dev, this may only be needed on Win10. Win11 shouldn't have this limitation, specifically Windows 10, version 2104 (build >10.0.20348.0)

NiiightmareXD/windows-capture#69

Please sign in to comment.