Decklink: Use v210 in high bitdepth color path #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
niklaspandersson
commented
Sep 23, 2024
•
niklaspandersson
commented
- Update decklink consumer to use v210 as pixelformat when using high bit-depth colors
- Refactor decklink consumer by introducing a format strategy pattern to separate code paths for 8bpc and 16bpc color frames
- Simplify bringing the "HDR" code path to feature parity with the 8bpc path
- Bumps the simd instruction set requirements to avx2. I don't know how you feel about this
- Better performance than 10RGBXLE
|
Perhaps important to mention here, the motivation for making this change was that 10RGBXLE doesn't work with all formats, for 4Kp30 and above decklink requires you to use v210. |
Julusian
approved these changes
Oct 7, 2024
| @@ -455,6 +465,7 @@ struct decklink_secondary_port final : public IDeckLinkVideoOutputCallback | |||
| int device_sync_group) | |||
| : config_(config) | |||
| , output_config_(std::move(output_config)) | |||
| , format_strategy_(new sdr_bgra_strategy()) | |||
There was a problem hiding this comment.
should this be hardcoded as sdr?
|
|
||
| namespace caspar { namespace decklink { | ||
|
|
||
| class hdr_v210_strategy |
There was a problem hiding this comment.
There's already the format_strategy interface, perhaps instead of using the pimpl pattern here it would be easier to use a loose create_hdr_v210_strategy function?
I don't mind either way, just wondering if the extra boilerplate that this approach has is beneficial.
Comment on lines
+82
to
+83
| // TODO: Add support for hdr frames | ||
|
|
There was a problem hiding this comment.
Suggested change
| // TODO: Add support for hdr frames |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.