fix dependency installation by conversion from setup.cfg to pyproject.toml #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherman64
commented
Dec 19, 2024
| pbr=True, | ||
| version='{{VERSION_PLACEHOLDER}}' | ||
| ) | ||
| setup(setup_requires=["pbr"]) |
There was a problem hiding this comment.
I had to change the invocation here, because if any arguments other than setup_requires was specified, PBR attempts to load the non-existing setup.cfg
There was a problem hiding this comment.
Thanks for pointing this out. I'm not sure if this changes how we were publishing to pypi, but I'll figure that out after merging.
Mark-Powers
reviewed
Dec 19, 2024
| build-backend = "pbr.build" | ||
|
|
||
| [project] | ||
| requires-python = ">=3.8" |
There was a problem hiding this comment.
I think we should say 3.10, Jupyter is using this at the moment, and that is typically our source of truth for is python-chi working.
Mark-Powers
approved these changes
Dec 19, 2024
|
Moved this back to draft, due to the following issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.